MaterialItem Done-Checkbox, API #7956
Conversation
💥 Feature branch deployment failed
|
pmattmann
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
carlobeltrame
left a comment
carlobeltrame
left a comment
There was a problem hiding this comment.
Guests can have material items assigned to them, but can never toggle the checkboxes. Is that the way we want it to work?
Also, the flag is still missing in the excel export. Please implement :)
| :layout-mode="layoutMode" | ||
| :material-item-collection="materialItemCollection" | ||
| :disabled="disabled" | ||
| :done-checklist-disabled="true" |
There was a problem hiding this comment.
IMO, the disabled state of the checkbox is not clearly recognizable, and in the current form I find the checkbox in the activity detail confusing. It's a checkbox which looks normal but I can't click it. If we insist on keeping it in the activity detail, I'd vote to display it as an icon instead of a checkbox (e.g. a checkmark icon if done, and no icon otherwise), to make it clear that it cannot be interacted with.
Also, maybe we could hide the column if none of the items have the flag set? To avoid it wasting space and being confusing at the same time?
| </template> | ||
|
|
||
| <template #[`item.done`]="{ item }"> | ||
| <api-checkbox |
There was a problem hiding this comment.
It should at the very least be vertically centered in the table row
|
|
||
| <template #[`item.done`]="{ item }"> | ||
| <api-checkbox | ||
| :disabled="layoutMode || doneChecklistDisabled || disabled" |
There was a problem hiding this comment.
Nice that you considered layoutMode, but in the activity detail and category detail view, doneChecklistDisabled is always set, isn't it?
carlobeltrame
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
pmattmann
had a problem deploying
to
feature-branch
GitHub Actions
Failure
pmattmann
changed the title
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
pmattmann
had a problem deploying
to
feature-branch
GitHub Actions
Failure
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
pmattmann
had a problem deploying
to
feature-branch
GitHub Actions
Failure
pmattmann
force-pushed
the
feature/checklist-item-done-checkbox
branch
from
4d527d7 to
5cd593c
Compare
pmattmann
force-pushed
the
feature/checklist-item-done-checkbox
branch
from
dcae7b2 to
a872bad
Compare
4 participants
Fixes #6218