-
Notifications
You must be signed in to change notification settings - Fork 62
Vue3 migration #8279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
manuelmeister
wants to merge
208
commits into
devel
Choose a base branch
from
vue3
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Vue3 migration #8279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
As far as I can tell, this would only affect us if we used the composition api more.
They are needed to build the frontend.
That we can build and deploy the frontend image.
✅ Feature branch deployment ready!
|
…nfig.js We will tackle this later.
Do not remove them yet from the rules section, that can be done later.
I did not find any docs to $i18n.browserPreferredLocale, and no docs that it was removed. But it's anyway better to use the browser standard.
Does not work yet on the register page. (But maybe never worked there). Found this with the .value here: https://vue-i18n.intlify.dev/guide/essentials/scope#local-scope-1
Don't know if this correct or good, but it works.
They don't work yet, but there is no referenceError.
This reverts commit bf4be47
The second parameter was an array after all.
The value given in is now a datetime string and not anymore a time.
It doesn't work yet, but it should look similar in the end.
…component This is just a quick hack. The correct way would be to not have reactive parts in the print config.
This was done with AI, but it seems to work somehow. We need to check if we really need all changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #8271 for todos