Skip to content

Updated deprecated syntax in storm_functions@L108 - raghu330:07/Aug/18 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

raghu330
Copy link

@raghu330 raghu330 commented Aug 7, 2018

Hello Oliver, Can you please update your master for the deprecation change. Basically bool-integer was not working out, so made use of np.subtract.

@ecjoliver
Copy link
Owner

Hi raghu330. I tried making the suggested change and there are two problems with it:

  1. using np.subtract takes much much longer than the original code. This is important as it will make the algorithm unusable when detecting over a multi-decadal data set.
  2. The results are not consistent with the original code. For a given global MSLP field (I tried 8 Sep 1851 00:00 from NCEP 20CR) The resulting code detected over 1400 mslp minima. The original code only detected 21. Consistent functionality is important.

If you can suggest a change that doesn't slow the code down and doesn't change behaviour I would merge it.

Regards, Eric

@subond
Copy link

subond commented Jan 10, 2019

Hi Oliver, Can you please provide all the best-fit preposition softs version information to run this stormTracking to me. I think it could include as follows: scipy numpy netcdf4 matplotlib basemap python=2.7. It seems that I always get a runtimewarning, no matter how I change the soft version. The warning is like that: storm_functions.py:95: RuntimeWarning: invalid value encountered in greater
regions, nregions = ndimage.label( (field>ssh_crit).astype(int) )
torm_functions.py:97: RuntimeWarning: invalid value encountered in less
regions, nregions = ndimage.label( (field<ssh_crit).astype(int) )
What's arong with it? How can I get rid of this error? Thank you Oliver!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants