Optimize access to custom license texts in Reporter #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oheger-bosch
requested review from
bs-ondem,
MarcelBochtler,
mnonnenmacher,
nnobelis and
sschuberth
as code owners
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
FYI, I also just created oss-review-toolkit/ort#9620 which generalizes the idea to a |
This was referenced Dec 16, 2024
Closed
oheger-bosch
force-pushed
the
reporter_custom_license_texts
branch
from
31885eb to
fa8921f
Compare
mnonnenmacher
requested changes
Dec 17, 2024
workers/reporter/src/main/kotlin/reporter/CustomLicenseTextProvider.kt
Outdated
Show resolved
Hide resolved
So far, ORT's `DefaultLicenceTextProvider` was used for accessing custom license texts. Practice has shown that this was rather inefficient because all license texts had to be downloaded to a local directory first. To avoid this, introduce a special implementation that directly interacts with the `ConfigManager` to download license texts. Signed-off-by: Oliver Heger <[email protected]>
oheger-bosch
force-pushed
the
reporter_custom_license_texts
branch
from
fa8921f to
9034c21
Compare
In `ReporterRunner`, create an instance of `CustomLicenseTextProvider` if a path to custom license texts is configured. This makes sure that custom license texts are obtained from the config repository on demand. Signed-off-by: Oliver Heger <[email protected]>
oheger-bosch
force-pushed
the
reporter_custom_license_texts
branch
from
9034c21 to
7f3182e
Compare
mnonnenmacher
approved these changes
Dec 17, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a special
LicenseTextProviderimplementation that optimizes loading of license texts from the config repository.