feat(core): Cache Keycloak roles for one minute #2329
Draft
+132
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnonnenmacher
force-pushed
the
role-cache
branch
from
85999d9 to
3db7b75
Compare
Requesting the user roles from Keycloak can take some time, slowing down endpoint which would otherwise respond very fast. For example, it was observed in a setup with Keycloak 24 that the Keycloak role requests took between 500-1000ms while the remaining request takes <50ms. This slows down the UI, especially on pages like the repository list, where a single page makes a lot of API requests. To mitigate the issue, cache Keycloak roles for one minute. This speeds up such UI pages while at the same time ensuring that changes in the Keycloak roles are quickly reflected by the UI. Signed-off-by: Martin Nonnenmacher <[email protected]>
mnonnenmacher
force-pushed
the
role-cache
branch
from
3db7b75 to
029a355
Compare
|
I did some tests and the duration for requesting the last run for each repository on the repositories page goes down from 500-1200ms to 45-250ms in a setup with a lot of Keycloak roles and Keycloak 24. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requesting the user roles from Keycloak can take some time, slowing down endpoint which would otherwise respond very fast. For example, it was observed in a setup with Keycloak 24 that the Keycloak role requests took between 500-1000ms while the remaining request takes <50ms.
This slows down the UI, especially on pages like the repository list, where a single page makes a lot of API requests.
To mitigate the issue, cache Keycloak roles for one minute. This speeds up such UI pages while at the same time ensuring that changes in the Keycloak roles are quickly reflected by the UI.