Add sync and workerd entrypoints for Cloudflare runtimes#61
Open
calclavia wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cloudflare Workers and other
workerd-style runtimes import.wasmassets as precompiledWebAssembly.Moduleobjects, while this package currently only publishes thewasm-pack --target bundlerentrypoint. That forces downstream consumers to patch the generated loader or maintain wrapper packages just to instantiatebiscuit-wasmin Cloudflare-style runtimes.This PR upstreams that runtime support without changing the existing bundler path.
@biscuit-auth/biscuit-wasm/syncentrypoint withinitSync(...)for runtimes that can provide a precompiledWebAssembly.Moduleor raw wasm bytesworkerdexport condition plus an explicit@biscuit-auth/biscuit-wasm/workerdsubpath that initializes frombiscuit_bg.wasmautomaticallyprepare-package, discovering snippet import paths from the built package instead of hardcoding wasm-bindgen hash directories in source./module/biscuit_bg.jsand./module/biscuit_bg.wasmsubpaths for custom loaders, and document the new runtime options in the READMEsyncentry against a precompiledWebAssembly.ModuleTest plan
npm run check-formatcargo fmt --checkcargo clippy -- -D warningsnpm run prepare-packagecd js-tests && npm install && npm testcd examples/node && npm install && npm start