Gdb Manual Remote launch targets for CoreBuild projects #1222
Conversation
|
Hi @betamaxbandit and @Kummallinen CoreBuildGdbManualRemoteLaunchConfigProvider is at the moment a modified copy of the provider for Local. It needs further cleanup which I would like to discuss about. With this change we will have working Gdb Remote launch targets for CMake and CoreBuild Makefile projects. |
|
|
||
| @Override | ||
| public boolean launchConfigurationChanged(ILaunchConfiguration configuration) throws CoreException { | ||
| // TODO Auto-generated method stub |
|
|
||
| @Override | ||
| public void launchTargetRemoved(ILaunchTarget target) throws CoreException { | ||
| // TODO Auto-generated method stub |
There was a problem hiding this comment.
O: if you're sure there is nothing to do then say it in a comment.
There was a problem hiding this comment.
I updated the method.
| * E.g. org.eclipse.cdt.debug.core.launch.CoreBuildGenericLaunchConfigProvider. | ||
| */ | ||
|
|
||
| public class CoreBuildGdbManualRemoteLaunchConfigProvider extends AbstractLaunchConfigProvider { |
There was a problem hiding this comment.
O: hmm, my experience of writing launch config providers for Renesas is to use ProjectPerTargetLaunchConfigProvider.
With that approach, it is expected that any values in the launch target (eg hostname, port) are copied from the launch target into the launch configuration during populateLaunchConfiguration.
Additionally we have a unique launch configuration per launch target, so in createLaunchConfiguration the name also contains the launch target ID, like this:
/*
* Suffix the launch configuration with the launch target name, so its obvious to the user which one they are
* using.
*/
String name = launchManager.generateLaunchConfigurationName(descriptor.getName()//
+ " " + target.getId());
When the user changes the launch target, the corresponding launch configuration is available when clicking the launchbar launch config gear. And any previously set values are shown.
Without this, I don't see the purpose of the launch target.
In this scenario, Renesas launch targets specify a target device. So maybe this approach is not appropriate when we're talking about a TCP/Serial connection.
This way of thinking for me may be so ingrained now that it's difficult for me to see any other way. Can you share your vision for this please?
There was a problem hiding this comment.
I updated my code. The launch config name is now unique and target attributes are populated into the configuration.
I did not know of ProjectPerTargetLaunchConfigProvider. It is not used in CDT, except in one test.
I will look into it.
Support the Gdb Remote TCP and Serial launch targets for CoreBuild projects. A new non-public LaunchConfiguration type is added, that is working with the same launch descriptor type as CoreBuild Local projects. Also a new LaunchConfigurationProvider that supports the Gdb Remote TCP and Serial targets is added. It makes use of the launch delegate org.eclipse.cdt.dsf.gdb.launching.GdbTargetedLaunchDelegate, which is also used for standard GDB (DSF) Manual Remote Debugging launch configurations for TCP and Serial connections. For the user is appears as if there is a single CoreBuild launch configuration that adapts dynamically to the launch target, while in reality there is a separate launch configuration for each target. Also cleanup up a bit CoreBuildGenericLaunchConfigProvider and fixed a bug in launchTargetRemoved(). Fixes eclipse-cdt#1168
ewaterlander
force-pushed
the
gdb_remote_target
branch
from
c85626c to
ddd704c
Compare
Support the Gdb Remote TCP and Serial launch targets for CoreBuild projects. A new non-public LaunchConfiguration type is added, that is working with the same launch descriptor type as CoreBuild Local projects. Also a new LaunchConfigurationProvider that supports the Gdb Remote TCP and Serial targets is added.
It makes use of the launch delegate
org.eclipse.cdt.dsf.gdb.launching.GdbTargetedLaunchDelegate, which is also used for standard GDB (DSF) Manual Remote Debugging launch configurations for TCP and Serial connections.
For the user is appears as if there is a single CoreBuild launch configuration that adapts dynamically to the launch target, while in reality there is a separate launch configuration for each target.
Fixes #1168