Skip to content

Update Getting Started page. #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025

Conversation

ewaterlander
Copy link
Contributor

  • Updated the Getting Started page to the new structure that was introduced in Getting Started documentation update. #1056 .
  • Removed the Installing and updating the CDT page. It was very outdated and already commented out in topics_Getting_Started.xml.

@ewaterlander
Copy link
Contributor Author

Hi @jld01
Would you like to review this change?

@jld01
Copy link
Contributor

jld01 commented Jul 1, 2025

Hi @jld01 Would you like to review this change?

HI @ewaterlander, good to see some work in this area. I can review, but probably next week.

Copy link
Contributor

@jld01 jld01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @ewaterlander. This change does highlight some inconsistency in tutorial page naming though.

@@ -34,16 +34,23 @@ The following tutorials guide you through the process of using the C/{cpp}
Development Toolkit (CDT) to:

* xref:cdt_w_prepare_workbench.adoc[Prepare the Workbench]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* xref:cdt_w_prepare_workbench.adoc[Prepare the Workbench]
* xref:cdt_w_prepare_workbench.adoc[Preparing the Workbench]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

** xref:new_cmake_proj.adoc[Creating a CMake project]
** xref:new_cbs_makefile_proj.adoc[Creating a Core Build System Makefile project]
** xref:cbs_using_existing_code.adoc[Using existing code]
** xref:cbs_launchbar.adoc[Launch Bar]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
** xref:cbs_launchbar.adoc[Launch Bar]
** xref:cbs_launchbar.adoc[Using the Launch Bar]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

* xref:cdt_w_debug.adoc[Debug a project]
* xref:cdt_w_existing_code.adoc[Import C/{cpp} source into Eclipse]
* xref:cdt_w_install_cdt.adoc[Install/update the CDT]
* xref:index_cbs.adoc[Core Build System]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* xref:index_cbs.adoc[Core Build System]
* xref:index_cbs.adoc[Using the Core Build System]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

** xref:cbs_build_project.adoc[Building a project]
** xref:cbs_run_project.adoc[Running a project]
** xref:cbs_debug_project.adoc[Debugging a project]
* xref:index_mbs.adoc[Legacy Managed Build System]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* xref:index_mbs.adoc[Legacy Managed Build System]
* xref:index_mbs.adoc[Using the legacy Managed Build System]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one I did not do, because it's an index page. Like index_cbs.adoc.
I did remove the " contents" suffix in the titles of index_[cm]bs.adoc.

* xref:cdt_w_existing_code.adoc[Import C/{cpp} source into Eclipse]
* xref:cdt_w_install_cdt.adoc[Install/update the CDT]
* xref:index_cbs.adoc[Core Build System]
** xref:core_build_system.adoc[Core Build System]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
** xref:core_build_system.adoc[Core Build System]
** xref:core_build_system.adoc[Using the Core Build System]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to adjust these bullet points to all use the same part of speech. However, this might imply changes to the title of the pages to which they point for consistency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

* Updated the Getting Started page to the new structure that was
  introduced in eclipse-cdt#1056 .
* Removed the Installing and updating the CDT. It was very outdated
  and already commented out in topics_Getting_Started.xml.
Copy link
Contributor

@jld01 jld01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, @ewaterlander .

@ewaterlander ewaterlander merged commit 57df2f1 into eclipse-cdt:main Jul 17, 2025
4 checks passed
@ewaterlander ewaterlander deleted the getting_started branch July 17, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants