Fix class member using declaration naming a constructor #1311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i-garrison
force-pushed
the
feature/member-using-declaration-base-constructor
branch
2 times, most recently
from
dad71d1 to
f5ad4ae
Compare
|
@i-garrison Thank you for your contribution. I am merging this under the special review policy. As I am in the middle of handling many of these PRs at once, I have done the build and test of them all in #1356 and I am applying the changes back to this PR so that it is tracked properly. |
jonahgraham
force-pushed
the
feature/member-using-declaration-base-constructor
branch
from
f5ad4ae to
dd420f5
Compare
i-garrison
deleted the
feature/member-using-declaration-base-constructor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently CDT parser would inject using declaration into class scope without checking if that names a base class constructor, which breaks name lookup.
Fix this and add unit test.