Skip to content

Conversation

i-garrison
Copy link
Contributor

  • implementation was already there but not wired to op_has_trivial_destructor

@i-garrison i-garrison force-pushed the feature/implement-builtin-has-trivial-destructor branch from e388d0f to 91d2dc3 Compare September 29, 2025 22:05
Copy link

github-actions bot commented Sep 29, 2025

Test Results

  584 files   -    34    584 suites   - 34   13m 40s ⏱️ - 22m 53s
9 886 tests  - 1 217  9 862 ✅  - 1 097  24 💤  - 120  0 ❌ ±0 
9 924 runs   - 1 217  9 900 ✅  - 1 097  24 💤  - 120  0 ❌ ±0 

Results for commit b324328. ± Comparison against base commit fc9f3ac.

This pull request removes 1217 tests.
org.eclipse.cdt.debug.gdbjtag.core.tests.jtagdevice.GDBJtagDeviceContributionTest ‑ testGdbJtagDeviceContribution
org.eclipse.cdt.debug.gdbjtag.core.tests.launch.GDBJtagLaunchTest ‑ testGdbJtagLaunch[gdb]
org.eclipse.cdt.debug.gdbjtag.core.tests.launch.GDBJtagLaunchTest ‑ testGdbJtagLaunch[gdbserver]
org.eclipse.cdt.tests.dsf.gdb.tests.CommandLineArgsTest ‑ testSettingArgumentsWithQuotes[gdb]
org.eclipse.cdt.tests.dsf.gdb.tests.CommandLineArgsTest ‑ testSettingArgumentsWithQuotes[gdbserver]
org.eclipse.cdt.tests.dsf.gdb.tests.CommandLineArgsTest ‑ testSettingArgumentsWithSpecialSymbols[gdb]
org.eclipse.cdt.tests.dsf.gdb.tests.CommandLineArgsTest ‑ testSettingArgumentsWithSpecialSymbols[gdbserver]
org.eclipse.cdt.tests.dsf.gdb.tests.CommandLineArgsTest ‑ testSettingArgumentsWithSymbols[gdb]
org.eclipse.cdt.tests.dsf.gdb.tests.CommandLineArgsTest ‑ testSettingArgumentsWithSymbols[gdbserver]
org.eclipse.cdt.tests.dsf.gdb.tests.CommandLineArgsTest ‑ testSettingArgumentsWithTabs[gdb]
…

♻️ This comment has been updated with latest results.

@ewaterlander
Copy link
Contributor

Hi,
The flaky test has been fixed. See #1318
You can rebase on main, or ignore the failure.

@i-garrison i-garrison force-pushed the feature/implement-builtin-has-trivial-destructor branch from 32854ba to b324328 Compare October 4, 2025 09:53
@jonahgraham jonahgraham added the language C/C++ Language Support label Oct 8, 2025
@jonahgraham
Copy link
Member

@i-garrison Thank you for your contribution. I am merging this under the special review policy. As I am in the middle of handling many of these PRs at once, I have done the build and test of them all in #1356 and I am applying the changes back to this PR so that it is tracked properly.

@jonahgraham jonahgraham force-pushed the feature/implement-builtin-has-trivial-destructor branch from b324328 to 60fa5ee Compare October 14, 2025 17:10
@jonahgraham jonahgraham added this to the 12.3.0 milestone Oct 14, 2025
@jonahgraham jonahgraham merged commit 60fa5ee into eclipse-cdt:main Oct 14, 2025
4 checks passed
@i-garrison i-garrison deleted the feature/implement-builtin-has-trivial-destructor branch October 14, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

language C/C++ Language Support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants