-
Couldn't load subscription status.
- Fork 217
Move connector.cdtserial and native.serial to new serial subfolder #1337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I am ok to move it around - but "It seems to be only used there" doesn't really apply in this case because it is a top-level feature, i.e. users can use the serial connector independently of other things. |
|
I might be misguided because it is referenced in the |
|
Debug.product is the CDT standalone debugger - the other main places it is referenced from are:
Probably best place is native/ because that is where its primary dependency lives. native/ could just as easily be renamed serial/ |
@laeubi thanks for starting this - I will take over here and do ☝️ |
2edf783 to
0dd555a
Compare
Renames native/ to serial/ as all that native/ had in it was serial port support. Moves the Eclipse Terminal serial connector from the terminal/ to serial/
0dd555a to
50d24f6
Compare
Never mind. I deleted the old org.eclipse.cdt.native.serial project and opened the new one in the serial folder. Fixed. |
|
@ewaterlander I am glad it is working now. xref to #1359 so others can see what this looks like on failure. |

It seems to be only used there... WDYT @jonahgraham @ruspl-afed ?