Skip to content

Conversation

@laeubi
Copy link
Contributor

@laeubi laeubi commented Oct 3, 2025

It seems to be only used there... WDYT @jonahgraham @ruspl-afed ?

@github-actions
Copy link

github-actions bot commented Oct 3, 2025

Test Results

   619 files  +   34     619 suites  +34   36m 48s ⏱️ + 22m 50s
11 131 tests +1 217  10 987 ✅ +1 097  144 💤 +120  0 ❌ ±0 
11 169 runs  +1 217  11 025 ✅ +1 097  144 💤 +120  0 ❌ ±0 

Results for commit 50d24f6. ± Comparison against base commit 2f5548d.

♻️ This comment has been updated with latest results.

@jonahgraham
Copy link
Member

I am ok to move it around - but "It seems to be only used there" doesn't really apply in this case because it is a top-level feature, i.e. users can use the serial connector independently of other things.

@laeubi
Copy link
Contributor Author

laeubi commented Oct 3, 2025

I might be misguided because it is referenced in the debug.product (!) if you think it better belongs elsewhere let me know!

@jonahgraham
Copy link
Member

Debug.product is the CDT standalone debugger - the other main places it is referenced from are:

Probably best place is native/ because that is where its primary dependency lives. native/ could just as easily be renamed serial/

@jonahgraham jonahgraham added releng Release engineering and project management terminal The TM Terminal collection of features in CDT labels Oct 8, 2025
@jonahgraham
Copy link
Member

Probably best place is native/ because that is where its primary dependency lives. native/ could just as easily be renamed serial/

@laeubi thanks for starting this - I will take over here and do ☝️

@jonahgraham jonahgraham force-pushed the move_serial_to_debug branch 2 times, most recently from 2edf783 to 0dd555a Compare October 14, 2025 19:42
@jonahgraham jonahgraham added this to the 12.3.0 milestone Oct 14, 2025
@jonahgraham jonahgraham changed the title Move connector.cdtserial to debug subfolder Move connector.cdtserial and native.serial to new serial subfolder Oct 14, 2025
Renames native/ to serial/ as all that native/ had in it was serial port
support.

Moves the Eclipse Terminal serial connector from the terminal/ to
serial/
@jonahgraham jonahgraham merged commit 50d24f6 into eclipse-cdt:main Oct 14, 2025
5 checks passed
@ewaterlander
Copy link
Contributor

Hi,

My Eclipse Committers IDE is now broken, because it does not see the contents of the new serial folder. For instance SerialPort can't be resolved now. Refreshing and restarting doesn't help.

image

@ewaterlander
Copy link
Contributor

Hi,

My Eclipse Committers IDE is now broken, because it does not see the contents of the new serial folder. For instance SerialPort can't be resolved now. Refreshing and restarting doesn't help.

Never mind. I deleted the old org.eclipse.cdt.native.serial project and opened the new one in the serial folder. Fixed.

@jonahgraham
Copy link
Member

@ewaterlander I am glad it is working now.

xref to #1359 so others can see what this looks like on failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releng Release engineering and project management terminal The TM Terminal collection of features in CDT

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants