Improving the Names Recommended by Extract Local Variable Refactoring #754
+450
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Addressing Issue 745.
|
@ruspl-afed @jld01 Please kindly review the pull request. |
|
Thanks @Michaelll123 for providing the same behaviour change to CDT as you did for JDT. Unfortunately no reviewers have found time to review it yet. Perhaps @jjohnstn may have some time to look at the code here too? |
jonahgraham
added
the
editor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Addressing issue #745
It is worth noting that the recommendation logic has been merged into the Eclipse (for Java). Here are the merged pull requests:
How to test
run testIfRecommend() in ExtractLocalVariableRefactoringTest.java.
Author checklist