Adapt CreateNewProjectIT #4668
Merged
Adapt CreateNewProjectIT #4668
+7
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Iliyan Velichkov <[email protected]>
Signed-off-by: Iliyan Velichkov <[email protected]>
Signed-off-by: Iliyan Velichkov <[email protected]>
…le#4617) --------- Signed-off-by: Iliyan Velichkov <[email protected]> Co-authored-by: Iliyan Velichkov <[email protected]>
Signed-off-by: Iliyan Velichkov <[email protected]>
Signed-off-by: Iliyan Velichkov <[email protected]>
Signed-off-by: Iliyan Velichkov <[email protected]>
Signed-off-by: Iliyan Velichkov <[email protected]>
Signed-off-by: Iliyan Velichkov <[email protected]>
* switch tests to the new UI Signed-off-by: Iliyan Velichkov <[email protected]> * MailIT works as well Signed-off-by: Iliyan Velichkov <[email protected]> * switch more tests to the new UI Signed-off-by: Iliyan Velichkov <[email protected]> --------- Signed-off-by: Iliyan Velichkov <[email protected]>
Signed-off-by: Iliyan Velichkov <[email protected]>
iliyan-velichkov
force-pushed
the
new-ui
branch
from
3a09179 to
ffe8415
Compare
Signed-off-by: Iliyan Velichkov <[email protected]>
|
@bob4o-afk resolve the conflicts - codeql is now enabled for all branches with commit 7b3f62b |
Signed-off-by: bobinkata <[email protected]>
|
@BorisNen please review this PR |
BorisNen
approved these changes
Feb 19, 2025
tests/tests-framework/src/main/java/org/eclipse/dirigible/tests/IDE.java
Outdated
Show resolved
Hide resolved
tests/tests-framework/src/main/java/org/eclipse/dirigible/tests/framework/impl/BrowserImpl.java
Outdated
Show resolved
Hide resolved
...tions/src/test/java/org/eclipse/dirigible/integration/tests/ui/tests/CreateNewProjectIT.java
Outdated
Show resolved
Hide resolved
BorisNen
requested changes
Feb 19, 2025
tests/tests-framework/src/main/java/org/eclipse/dirigible/tests/IDE.java
Outdated
Show resolved
Hide resolved
tests/tests-framework/src/main/java/org/eclipse/dirigible/tests/IDE.java
Outdated
Show resolved
Hide resolved
tests/tests-framework/src/main/java/org/eclipse/dirigible/tests/framework/impl/BrowserImpl.java
Outdated
Show resolved
Hide resolved
Signed-off-by: bobinkata <[email protected]>
Signed-off-by: bobinkata <[email protected]>
Signed-off-by: bobinkata <[email protected]>
BorisNen
approved these changes
Feb 20, 2025
iliyan-velichkov
requested changes
Feb 20, 2025
tests/tests-framework/src/main/java/org/eclipse/dirigible/tests/framework/HtmlElementType.java
Outdated
Show resolved
Hide resolved
tests/tests-framework/src/main/java/org/eclipse/dirigible/tests/framework/HtmlElementType.java
Outdated
Show resolved
Hide resolved
tests/tests-framework/src/main/java/org/eclipse/dirigible/tests/framework/impl/BrowserImpl.java
Outdated
Show resolved
Hide resolved
tests/tests-framework/src/main/java/org/eclipse/dirigible/tests/framework/impl/BrowserImpl.java
Outdated
Show resolved
Hide resolved
iliyan-velichkov
requested changes
Feb 20, 2025
tests/tests-framework/src/main/java/org/eclipse/dirigible/tests/framework/impl/BrowserImpl.java
Outdated
Show resolved
Hide resolved
Comment on lines
415
to
417
| By selector = constructCssLocatorByType(elementType); | ||
|
|
||
| findElementInAllFrames(selector, Condition.exist, Condition.exactText(text)); |
There was a problem hiding this comment.
you have to search for element with class attribute which have given value and contains exact text
There was a problem hiding this comment.
it is replaced with "By selector = constructCssSelectorByType(elementType); " as it was, because now it uses " browser.assertElementExistsByTypeAndText(HtmlElementType.SPAN, expectedMessage);"
tests/tests-framework/src/main/java/org/eclipse/dirigible/tests/IDE.java
Show resolved
Hide resolved
iliyan-velichkov
approved these changes
Feb 21, 2025
iliyan-velichkov
added a commit
that referenced
this pull request
Feb 21, 2025
* add dummy change Signed-off-by: Iliyan Velichkov <[email protected]> * enable new UI by default Signed-off-by: Iliyan Velichkov <[email protected]> * fix tests execution - run them with the old UI until adapted Signed-off-by: Iliyan Velichkov <[email protected]> * Changed DirigibleHomepageIT test to work with new UI (#4617) --------- Signed-off-by: Iliyan Velichkov <[email protected]> Co-authored-by: Iliyan Velichkov <[email protected]> * add generic solution to reload config after test classes Signed-off-by: Iliyan Velichkov <[email protected]> * make openWorkbench to work with the new and the old UI Signed-off-by: Iliyan Velichkov <[email protected]> * format the code Signed-off-by: Iliyan Velichkov <[email protected]> * improve failure messages and elements search Signed-off-by: Iliyan Velichkov <[email protected]> * don't let the logs to affect the matching, increase search time Signed-off-by: Iliyan Velichkov <[email protected]> * switch tests to the new UI (#4657) * switch tests to the new UI Signed-off-by: Iliyan Velichkov <[email protected]> * MailIT works as well Signed-off-by: Iliyan Velichkov <[email protected]> * switch more tests to the new UI Signed-off-by: Iliyan Velichkov <[email protected]> --------- Signed-off-by: Iliyan Velichkov <[email protected]> * reduce ELEMENT_SEARCH_IN_FRAME_MILLIS (#4663) Signed-off-by: Iliyan Velichkov <[email protected]> * fix: fixing test * codeql on all branches Signed-off-by: Iliyan Velichkov <[email protected]> * Update IDE.java Signed-off-by: bobinkata <[email protected]> * Update BrowserImpl.java Signed-off-by: bobinkata <[email protected]> * Update CreateNewProjectIT.java Signed-off-by: bobinkata <[email protected]> * fix: fixing comments * fix: fixing comments * fix: fixing comments --------- Signed-off-by: Iliyan Velichkov <[email protected]> Signed-off-by: bobinkata <[email protected]> Co-authored-by: Iliyan Velichkov <[email protected]> Co-authored-by: Valentin <[email protected]>
iliyan-velichkov
added a commit
that referenced
this pull request
Feb 21, 2025
* add dummy change Signed-off-by: Iliyan Velichkov <[email protected]> * enable new UI by default Signed-off-by: Iliyan Velichkov <[email protected]> * fix tests execution - run them with the old UI until adapted Signed-off-by: Iliyan Velichkov <[email protected]> * Changed DirigibleHomepageIT test to work with new UI (#4617) --------- Signed-off-by: Iliyan Velichkov <[email protected]> Co-authored-by: Iliyan Velichkov <[email protected]> * add generic solution to reload config after test classes Signed-off-by: Iliyan Velichkov <[email protected]> * make openWorkbench to work with the new and the old UI Signed-off-by: Iliyan Velichkov <[email protected]> * format the code Signed-off-by: Iliyan Velichkov <[email protected]> * improve failure messages and elements search Signed-off-by: Iliyan Velichkov <[email protected]> * don't let the logs to affect the matching, increase search time Signed-off-by: Iliyan Velichkov <[email protected]> * switch tests to the new UI (#4657) * switch tests to the new UI Signed-off-by: Iliyan Velichkov <[email protected]> * MailIT works as well Signed-off-by: Iliyan Velichkov <[email protected]> * switch more tests to the new UI Signed-off-by: Iliyan Velichkov <[email protected]> --------- Signed-off-by: Iliyan Velichkov <[email protected]> * reduce ELEMENT_SEARCH_IN_FRAME_MILLIS (#4663) Signed-off-by: Iliyan Velichkov <[email protected]> * fix: fixing test * codeql on all branches Signed-off-by: Iliyan Velichkov <[email protected]> * Update IDE.java Signed-off-by: bobinkata <[email protected]> * Update BrowserImpl.java Signed-off-by: bobinkata <[email protected]> * Update CreateNewProjectIT.java Signed-off-by: bobinkata <[email protected]> * fix: fixing comments * fix: fixing comments * fix: fixing comments --------- Signed-off-by: Iliyan Velichkov <[email protected]> Signed-off-by: bobinkata <[email protected]> Co-authored-by: Iliyan Velichkov <[email protected]> Co-authored-by: Valentin <[email protected]>
iliyan-velichkov
added a commit
that referenced
this pull request
Feb 21, 2025
* add dummy change Signed-off-by: Iliyan Velichkov <[email protected]> * enable new UI by default Signed-off-by: Iliyan Velichkov <[email protected]> * fix tests execution - run them with the old UI until adapted Signed-off-by: Iliyan Velichkov <[email protected]> * Changed DirigibleHomepageIT test to work with new UI (#4617) --------- Signed-off-by: Iliyan Velichkov <[email protected]> Co-authored-by: Iliyan Velichkov <[email protected]> * add generic solution to reload config after test classes Signed-off-by: Iliyan Velichkov <[email protected]> * make openWorkbench to work with the new and the old UI Signed-off-by: Iliyan Velichkov <[email protected]> * format the code Signed-off-by: Iliyan Velichkov <[email protected]> * improve failure messages and elements search Signed-off-by: Iliyan Velichkov <[email protected]> * don't let the logs to affect the matching, increase search time Signed-off-by: Iliyan Velichkov <[email protected]> * switch tests to the new UI (#4657) * switch tests to the new UI Signed-off-by: Iliyan Velichkov <[email protected]> * MailIT works as well Signed-off-by: Iliyan Velichkov <[email protected]> * switch more tests to the new UI Signed-off-by: Iliyan Velichkov <[email protected]> --------- Signed-off-by: Iliyan Velichkov <[email protected]> * reduce ELEMENT_SEARCH_IN_FRAME_MILLIS (#4663) Signed-off-by: Iliyan Velichkov <[email protected]> * Adapt CreateNewProjectIT (#4668) * add dummy change Signed-off-by: Iliyan Velichkov <[email protected]> * enable new UI by default Signed-off-by: Iliyan Velichkov <[email protected]> * fix tests execution - run them with the old UI until adapted Signed-off-by: Iliyan Velichkov <[email protected]> * Changed DirigibleHomepageIT test to work with new UI (#4617) --------- Signed-off-by: Iliyan Velichkov <[email protected]> Co-authored-by: Iliyan Velichkov <[email protected]> * add generic solution to reload config after test classes Signed-off-by: Iliyan Velichkov <[email protected]> * make openWorkbench to work with the new and the old UI Signed-off-by: Iliyan Velichkov <[email protected]> * format the code Signed-off-by: Iliyan Velichkov <[email protected]> * improve failure messages and elements search Signed-off-by: Iliyan Velichkov <[email protected]> * don't let the logs to affect the matching, increase search time Signed-off-by: Iliyan Velichkov <[email protected]> * switch tests to the new UI (#4657) * switch tests to the new UI Signed-off-by: Iliyan Velichkov <[email protected]> * MailIT works as well Signed-off-by: Iliyan Velichkov <[email protected]> * switch more tests to the new UI Signed-off-by: Iliyan Velichkov <[email protected]> --------- Signed-off-by: Iliyan Velichkov <[email protected]> * reduce ELEMENT_SEARCH_IN_FRAME_MILLIS (#4663) Signed-off-by: Iliyan Velichkov <[email protected]> * fix: fixing test * codeql on all branches Signed-off-by: Iliyan Velichkov <[email protected]> * Update IDE.java Signed-off-by: bobinkata <[email protected]> * Update BrowserImpl.java Signed-off-by: bobinkata <[email protected]> * Update CreateNewProjectIT.java Signed-off-by: bobinkata <[email protected]> * fix: fixing comments * fix: fixing comments * fix: fixing comments --------- Signed-off-by: Iliyan Velichkov <[email protected]> Signed-off-by: bobinkata <[email protected]> Co-authored-by: Iliyan Velichkov <[email protected]> Co-authored-by: Valentin <[email protected]> * cleanup Signed-off-by: Iliyan Velichkov <[email protected]> * cleanup and refactoring Signed-off-by: Iliyan Velichkov <[email protected]> * configs refactoring Signed-off-by: Iliyan Velichkov <[email protected]> * refactoring Signed-off-by: Iliyan Velichkov <[email protected]> --------- Signed-off-by: Iliyan Velichkov <[email protected]> Signed-off-by: bobinkata <[email protected]> Co-authored-by: Valentin <[email protected]> Co-authored-by: bobinkata <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adapting test CreateNewProjectIT with the new UI
Fixes codbex/codbex-platform-development#4
What issues does this PR fix or reference?
It fixes the way of finding the correct elements.
Adapt test CreateNewProjectIT
Release Notes
Documentation