improve streaming of jsonstrings#133
Open
sebastian-toepfer wants to merge 2 commits intoeclipse-ee4j:masterfrom
Open
improve streaming of jsonstrings#133sebastian-toepfer wants to merge 2 commits intoeclipse-ee4j:masterfrom
sebastian-toepfer wants to merge 2 commits intoeclipse-ee4j:masterfrom
Conversation
added 2 commits
June 10, 2024 21:01
the for loop needs the length of the current string and than access the char character by character via charAt. this prevents the JsonString from reloading its content. the foreach from stream retrieve char by char without knowing the end. so the jsonstring can be extended and reloading his content from a source (like a database). this approach also fits the buffer of the generator > the string supplies the char at the same speed at which the generator can fill and write the buffer. Signed-off-by: Sebastian Toepfer <sebastian+eclipse@toepfers.eu>
not realy needed, only to ensure the idea works Signed-off-by: Sebastian Toepfer <sebastian+eclipse@toepfers.eu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this change enables a smoother streaming of string values. The standard stringimpl. has neither advantages nor disadvantages, but with this change in place a client can create his own version of JsonString which than can lazyload its content from a source.