Support for ISO_DATE to Date deserialization#648
Open
OndroMih wants to merge 2 commits intoeclipse-ee4j:masterfrom
Open
Support for ISO_DATE to Date deserialization#648OndroMih wants to merge 2 commits intoeclipse-ee4j:masterfrom
OndroMih wants to merge 2 commits intoeclipse-ee4j:masterfrom
Conversation
Author
|
Hi, @Verdent, can you have a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #487.
Deserializes plain ISO_DATE, e.g. "2024-08-21" to
java.util.Datein the default system timezone. The reason is that the date is meant to be a date and not exact time. So the final Date instance has the same date in the local timezone as the date on the input.Dealing with timezones is a bit confusing to me. If somebody thinks it's better to convert the date using UTC, let me know. However, I think the default timezone is a reasonable default.