Skip to content

Conversation

@Eddykasp
Copy link
Member

allow putting each node in a split layer alone in a sublayer
removes an unnecessary restriction in the layer splitting option

allow putting each node in a split layer alone in a sublayer
@Eddykasp Eddykasp added this to the Release 0.12.0 milestone Sep 18, 2025
@Eddykasp Eddykasp added the alg-layered Affects the ELK Layered algorithm. label Sep 18, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the condition for layer splitting logic to allow placing each node in a split layer alone in a sublayer, removing an unnecessary restriction.

  • Changed the layer splitting condition from "more nodes than resulting sub-layers" to "enough nodes to fill the resulting sub-layers"
  • Modified the comparison operator from > to >= in the splitting logic
  • Updated the corresponding comment to reflect the new behavior

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Eddykasp
Copy link
Member Author

the elkjs build can't find the melk 0.11.0-SNAPSHOT, but updating to 0.12.0-SNAPSHOT (https://github.com/kieler/elkjs/pull/357/files) also doesn't work... Did something change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

alg-layered Affects the ELK Layered algorithm.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants