Skip to content

rust version update#135

Closed
fprezado wants to merge 1 commit intoeclipse-ibeji:mainfrom
fprezado:fprezado/rust-version-update
Closed

rust version update#135
fprezado wants to merge 1 commit intoeclipse-ibeji:mainfrom
fprezado:fprezado/rust-version-update

Conversation

@fprezado
Copy link
Contributor

@fprezado fprezado commented Apr 7, 2025

rust version update to latest. compiled and tested on aarch64

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

.cargo/config.toml:2

  • Removal of rustflags might affect static linking on aarch64. Confirm that this change is intentional and update the configuration if necessary.
rustflags = [ "-C", "target-feature=+crt-static", "-C", "link-arg=-lgcc" ]

samples/streaming/consumer/src/main.rs:9

  • Verify that the updated import for ImageReader is correct with the new version of the image crate, ensuring compatibility with the rest of the code.
use image::{DynamicImage, ImageReader};

@fprezado
Copy link
Contributor Author

fprezado commented Apr 7, 2025

closing pull request as although cargo build and cargo test built and tested successfully, cargo clippy identified additional issues:

error: doc list item overindented
--> core/common/src/grpc_server.rs:37:9
|
37 | /// added with .layer().
| ^^^^^^^^^^^^^^^^^ help: try using (2 spaces)
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items
= note: -D clippy::doc-overindented-list-items implied by -D warnings
= help: to override -D warnings add #[allow(clippy::doc_overindented_list_items)]

error: call to reserve immediately after creation
--> core/common/src/sample_grpc_interceptor.rs:65:9
|
65 | / let mut new_protobuf_message_buf: Vec = Vec::new();
66 | | new_protobuf_message_buf.reserve(register_request.encoded_len());
| |_________________________________________________________________________^ help: consider using Vec::with_capacity(/* Space hint */): let mut new_protobuf_message_buf: Vec<u8> = Vec::with_capacity(register_request.encoded_len());

error: call to reserve immediately after creation
--> core/common/src/sample_grpc_interceptor.rs:88:9
|
88 | / let mut new_protobuf_message_buf: Vec = Vec::new();
89 | | new_protobuf_message_buf.reserve(register_response.encoded_len());
| |__________________________________________________________________________^ help: consider using Vec::with_capacity(/* Space hint */): let mut new_protobuf_message_buf: Vec<u8> = Vec::with_capacity(register_response.encoded_len());

@fprezado fprezado closed this Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants