Skip to content

Fix minor issues in dynsec plugin#3643

Open
SteveHamann wants to merge 7 commits into
eclipse-mosquitto:masterfrom
SteveHamann:fix-minor-issues-in-dynsec-plugin
Open

Fix minor issues in dynsec plugin#3643
SteveHamann wants to merge 7 commits into
eclipse-mosquitto:masterfrom
SteveHamann:fix-minor-issues-in-dynsec-plugin

Conversation

@SteveHamann

@SteveHamann SteveHamann commented May 7, 2026

Copy link
Copy Markdown
Contributor

Thank you for contributing your time to the Mosquitto project!

Before you go any further, please note that we cannot accept contributions if
you haven't signed the Eclipse Contributor Agreement.
If you aren't able to do that, or just don't want to, please describe your bug
fix/feature change in an issue. For simple bug fixes it is can be just as easy
for us to be told about the problem and then go fix it directly.

Then please check the following list of things we ask for in your pull request:

  • Have you signed the Eclipse Contributor Agreement, using the same email address as you used in your commits?
  • Do each of your commits have a "Signed-off-by" line, with the correct email address? Use "git commit -s" to generate this line for you.
  • If you are contributing a new feature, is your work based off the develop branch?
  • If you are contributing a bugfix, is your work based off the fixes branch?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run make test with your changes locally?

This PR includes minor improvements of the Dynamic Security Plugin. It improves validation of priority values, fixes issues in memory management and corrects the algorithm for generating random passwords on init. Where missing additional tests have been implemented to verify the correctness of the changes. This also includes a new directory for unit tests of the Dynamic Security Plugin.

@codecov

codecov Bot commented May 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 72.22222% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
plugins/dynamic-security/clients.c 45.45% 6 Missing ⚠️
plugins/dynamic-security/roles.c 40.00% 3 Missing ⚠️
plugins/dynamic-security/config_init.c 85.71% 1 Missing ⚠️
Files with missing lines Coverage Δ
plugins/dynamic-security/groups.c 85.06% <100.00%> (+1.27%) ⬆️
plugins/dynamic-security/rolelist.c 83.16% <100.00%> (+0.99%) ⬆️
plugins/dynamic-security/utils.c 100.00% <100.00%> (ø)
plugins/dynamic-security/config_init.c 72.86% <85.71%> (-0.11%) ⬇️
plugins/dynamic-security/roles.c 82.44% <40.00%> (+0.97%) ⬆️
plugins/dynamic-security/clients.c 81.95% <45.45%> (+0.57%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- Add unit test dir for DynSec plugin
- Add unit test for DynSec plugin utils

Signed-off-by: Steve Hamann <steve.hamann@cedalo.com>
- Remove unnecessary call to dynsec__remove_client_from_all_groups
- Add missing mosquitto_free calls

Signed-off-by: Steve Hamann <steve.hamann@cedalo.com>
Signed-off-by: Steve Hamann <steve.hamann@cedalo.com>
Signed-off-by: Steve Hamann <steve.hamann@cedalo.com>
Signed-off-by: Steve Hamann <steve.hamann@cedalo.com>
Signed-off-by: Steve Hamann <steve.hamann@cedalo.com>
- Use correct sizes for byte (256) and password character pool (80) to
  achieve a theoretically equal distribution of the available password
  chars.

Signed-off-by: Steve Hamann <steve.hamann@cedalo.com>
@SteveHamann
SteveHamann force-pushed the fix-minor-issues-in-dynsec-plugin branch from 6867ab1 to 993ca83 Compare May 13, 2026 10:18
@ralight
ralight force-pushed the master branch 2 times, most recently from 73e732b to db988a6 Compare May 18, 2026 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant