Fix minor issues in dynsec plugin#3643
Open
SteveHamann wants to merge 7 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
- Add unit test dir for DynSec plugin - Add unit test for DynSec plugin utils Signed-off-by: Steve Hamann <steve.hamann@cedalo.com>
- Remove unnecessary call to dynsec__remove_client_from_all_groups - Add missing mosquitto_free calls Signed-off-by: Steve Hamann <steve.hamann@cedalo.com>
Signed-off-by: Steve Hamann <steve.hamann@cedalo.com>
Signed-off-by: Steve Hamann <steve.hamann@cedalo.com>
Signed-off-by: Steve Hamann <steve.hamann@cedalo.com>
Signed-off-by: Steve Hamann <steve.hamann@cedalo.com>
- Use correct sizes for byte (256) and password character pool (80) to achieve a theoretically equal distribution of the available password chars. Signed-off-by: Steve Hamann <steve.hamann@cedalo.com>
SteveHamann
force-pushed
the
fix-minor-issues-in-dynsec-plugin
branch
from
May 13, 2026 10:18
6867ab1 to
993ca83
Compare
ralight
force-pushed
the
master
branch
2 times, most recently
from
May 18, 2026 23:07
73e732b to
db988a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing your time to the Mosquitto project!
Before you go any further, please note that we cannot accept contributions if
you haven't signed the Eclipse Contributor Agreement.
If you aren't able to do that, or just don't want to, please describe your bug
fix/feature change in an issue. For simple bug fixes it is can be just as easy
for us to be told about the problem and then go fix it directly.
Then please check the following list of things we ask for in your pull request:
make testwith your changes locally?This PR includes minor improvements of the Dynamic Security Plugin. It improves validation of priority values, fixes issues in memory management and corrects the algorithm for generating random passwords on init. Where missing additional tests have been implemented to verify the correctness of the changes. This also includes a new directory for unit tests of the Dynamic Security Plugin.