Fix bind_interface support guard#3654
Open
kmehltretter82 wants to merge 1 commit into
Open
Conversation
The bind_interface parser guard still checked SO_BINDTODEVICE, but the runtime implementation no longer uses SO_BINDTODEVICE. It uses getifaddrs() on non-Windows/non-AIX platforms instead. This caused bind_interface to be rejected at config parse time on platforms where the runtime implementation is available, including macOS. Add a HAVE_BIND_INTERFACE guard and use it consistently for parsing, the ifaddrs include, the bind helper, and the call site. This fixes test/broker/16-config-huge.py on macOS. Assisted-by: OpenAI Codex (GPT-5) Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bind_interface parser guard still checked SO_BINDTODEVICE, but the runtime implementation no longer uses SO_BINDTODEVICE. It uses getifaddrs() on non-Windows/non-AIX platforms instead.
This caused bind_interface to be rejected at config parse time on platforms where the runtime implementation is available, including macOS.
Add a HAVE_BIND_INTERFACE guard and use it consistently for parsing, the ifaddrs include, the bind helper, and the call site. This fixes test/broker/16-config-huge.py on macOS.
Assisted-by: OpenAI Codex (GPT-5)
Thank you for contributing your time to the Mosquitto project!
Before you go any further, please note that we cannot accept contributions if
you haven't signed the Eclipse Contributor Agreement.
If you aren't able to do that, or just don't want to, please describe your bug
fix/feature change in an issue. For simple bug fixes it is can be just as easy
for us to be told about the problem and then go fix it directly.
Then please check the following list of things we ask for in your pull request:
make testwith your changes locally?Tested with:
cmake --build buildenv PATH="$PWD/build/test-venv/bin:$PATH" ctest --test-dir build --output-on-failure --parallel 1