Clean-up code related to AlreadySignExtended register flag #8058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In eclipse-omr#8035 we introduced a new node flag to notify the code-gen that the node was sign extended when evaluated. This removes the the use of AlreadySignExtended register flag which can be propagated to other nodes if the register is reused through clobber evaluation of the node. This commit includes the clean-up related AlreadySignExtended register flag. Signed-off-by: Rahil Shah <[email protected]>
r30shah
force-pushed
the
removeAlreadySignExtendedFlag
branch
from
eae5121 to
f470de9
Compare
Contributor
Author
|
As recommended in #8035 (review) , opening up this PR to clean-up AlreadySignExtended flag. @joransiu / @hzongaro Can I request your review on this change ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #8035 we introduced a new node flag to notify the code-gen that the node was sign extended when evaluated. This removes the the use of AlreadySignExtended register flag which can be propagated to other nodes if the register is reused through clobber evaluation of the node.
This commit includes the clean-up related AlreadySignExtended register flag.