[I/Y-Build] Move RelEng Build Tools ANT tasks as plain Java scripts into this repository #3555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HannesWell
force-pushed
the
build-java-scripts
branch
2 times, most recently
from
f9f9461 to
b4ac006
Compare
The following Java files are copied from https://github.com/eclipse-platform/eclipse.platform.releng.buildtools at commitId: af458820007ba53a290d47a76ec58bd4e9ceef9e respectively from https://github.com/eclipse-platform/eclipse.platform.releng.buildtools/tree/af458820007ba53a290d47a76ec58bd4e9ceef9e Add the generator classes: - org.eclipse.releng.generators.TestResultsGenerator as TestResultsGenerator - org.eclipse.releng.generators.ErrorTracker as ErrorTracker - org.eclipse.releng.generators.PlatformStatus as PlatformStatus Add org.eclipse.releng.build.tools.comparator.Extractor as ComparatorSummaryExtractor Add org.eclipse.releng.build.tools.convert.ant.Converter as CompileLogConverter Add relevant classes from package org.eclipse.releng.build.tools.convert.dom to package log.convert (with same name) In all copied source files spaces are replaced by tabs and all files are formated, but not changed further. They don't compile successfully in this state and are only adapted subsequently.
HannesWell
force-pushed
the
build-java-scripts
branch
from
b4ac006 to
6323b9c
Compare
Convert the previous ANT tasks classes to plain Java Source-Code Programs that can be launched directly from source via the 'java' command, without being compiled. Arguments are read as system properties. This leverages JEP-458 - 'Launch Multi-File Source-Code Programs': https://openjdk.org/jeps/458 With this and the previous commit, this makes this repository independent from eclipse.platform.releng.buildtools. Therefore the latter is removed from the Oomph-setup of the Platform.
HannesWell
force-pushed
the
build-java-scripts
branch
from
6323b9c to
13378e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all RelEng Build Tools ANT tasks currently in use into this repository and convert them to plain Java scripts so that they can be launched as (Multi-File) Source-Code Programs by just invoking the
javacommand (and setting the required system properties).In detail the following Java files are copied from https://github.com/eclipse-platform/eclipse.platform.releng.buildtools/tree/af458820007ba53a290d47a76ec58bd4e9ceef9e
org.eclipse.releng.generators.TestResultsGeneratorasTestResultsGeneratororg.eclipse.releng.generators.ErrorTrackerasErrorTrackerorg.eclipse.releng.generators.PlatformStatusasPlatformStatusorg.eclipse.releng.build.tools.comparator.ExtractorasComparatorSummaryExtractororg.eclipse.releng.build.tools.convert.ant.ConverterasCompileLogConverterorg.eclipse.releng.build.tools.convert.domto packagelog.convert(with same name)In all copied source files spaces are replaced by tabs and all files are formated, but not changed further.
They don't compile successfully in this state and are only adapted subsequently.
This will also significantly simplify the build changes required for
And a significant part of the code added with this PR can be removed again if only data are written to JSON files instead of outputting html files.
Furthermore this makes the eclipse.platform.releng.buildtools repository obsolete for this repository.