-
Notifications
You must be signed in to change notification settings - Fork 175
Refactor: Move Win32-specific DPI logic to Win32DPIUtils #2281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Refactor: Move Win32-specific DPI logic to Win32DPIUtils #2281
Conversation
Test Results 546 files + 1 546 suites +1 27m 28s ⏱️ - 1m 26s For more details on these failures, see this check. Results for commit c098aaf. ± Comparison against base commit 6842283. This pull request removes 11 and adds 12 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
af4f446
to
ff7496a
Compare
ff7496a
to
f28ddd3
Compare
There are quite few changes in this PR. Could you please split it into several commits so I can review better? Try to split the commits where you used automated refactorings and mention "made by using only automated refactoring 'xyz'" in the commit-text. There are also compile errors. |
b18c683
to
2a71902
Compare
Removing all autoScale method from DPIUtil and replace it usages with scaleDown/Up method and pass the zoom from the caller side
2a71902
to
327a528
Compare
327a528
to
1143bb0
Compare
This commit introduces a dedicated Win32DPIUtils class to isolate Win32-specific DPI logic, improving platform separation and maintainability. Refactored moving with eclipse refactoring tool.
1143bb0
to
c098aaf
Compare
This commit introduces a dedicated Win32DPIUtils class to isolate Win32-specific DPI logic, improving platform separation and maintainability.
This PR:
Remove all the usages of autoScale methods in windows.
Move the scaleDown/Up method to windows specific DPIUtil
Move Win32 DPIUtil related test to Win32 DPIUtil test class.
Required: Refactor: Move GTK-specific DPI logic to GtkDPIUtil #2280