Scale Table.EXPLORER_EXTRA by zoom level instead of using fixed pixels #2452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoch-yatta
reviewed
Aug 29, 2025
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Table.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Table.java
Show resolved
Hide resolved
ShahzaibIbrahim
force-pushed
the
master-404-TABLE-EXPLORER_EXTRA
branch
2 times, most recently
from
e1345db to
e974783
Compare
|
@ShahzaibIbrahim Are you sure about your How To Test? With the SnippetExplorer I don't run into any of the usages of this constants. |
I might have mentioned wrong snippet here. I will check and confirm it in a bit. Edit: It was a snippet 7, I mistyped. @akoch-yatta |
ShahzaibIbrahim
force-pushed
the
master-404-TABLE-EXPLORER_EXTRA
branch
from
e974783 to
66955f7
Compare
akoch-yatta
force-pushed
the
master-404-TABLE-EXPLORER_EXTRA
branch
from
66955f7 to
c5275cb
Compare
akoch-yatta
approved these changes
Sep 4, 2025
akoch-yatta
force-pushed
the
master-404-TABLE-EXPLORER_EXTRA
branch
2 times, most recently
from
359f83d to
98fcc9a
Compare
The Table.VISTA_EXTRA and Table.EXPLORER_EXTRA constants specify additional spacing applied to table items when using the Vista or Explorer themes. Previously, both were defined as fixed pixel values, which worked at 100% zoom but did not scale properly on high-DPI monitors. This change redefines VISTA_EXTRA and EXPLORER_EXTRA in points and converts them to pixels based on the current zoom level, ensuring consistent spacing for themed table items across different display scales.
akoch-yatta
force-pushed
the
master-404-TABLE-EXPLORER_EXTRA
branch
from
98fcc9a to
f99943d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Table.VISTA_EXTRA and Table.EXPLORER_EXTRA constants specify additional spacing applied to table items when using the Vista or Explorer themes. Previously, both were defined as fixed pixel values, which worked at 100% zoom but did not
scale properly on high-DPI monitors.
This change redefines VISTA_EXTRA and EXPLORER_EXTRA in points and converts them to pixels based on the current zoom level, ensuring consistent spacing for themed table items across different display scales.
How to Test