Fix test leak detection in JUnit tests #2686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahgraham
added a commit
to jonahgraham/eclipse.platform.swt
that referenced
this pull request
Oct 28, 2025
In eclipse-platform#2686 I fixed/reenabled the leak detection reporting. This PR introduces a leaked image (and disables most tests) to verify that eclipse-platform#2686 really is working.
|
😢 Unfortunately with leak detection not running for sometime some resources leaks have snuck into the testsuite. Positive side is that at least some the leaks are in the tests I just wrote for the clipboard. I created PR #2687 to verify that leak detection worked, but clearly it does again now! |
While working on eclipse-platform#2685 and specifically trying to verify that change fixes the comment below \* I realized that a migration step was missed changing the suites from JUnit4 to JUnit5. On JUnit5 the `@BeforeAll` and `@AfterAll` only apply to the tests in the class itself, not to `@SelectClasses` too. Instead JUnit5 provides `@BeforeSuite` and `@AfterSuite` \* this comment: > For some reason, printing to System.err in JUnit test has no effect
jonahgraham
force-pushed
the
fix-leak-detection
branch
from
ccd5e07 to
827988f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #2685 and specifically trying to verify that change fixes the comment below * I realized that a migration step was missed changing the suites from JUnit4 to JUnit5.
On JUnit5 the
@BeforeAlland@AfterAllonly apply to the tests in the class itself, not to@SelectClassestoo.Instead JUnit5 provides
@BeforeSuiteand@AfterSuite* this comment: