Replace PROJECT_OPEN_NEW_PERSPECTIVE Constant with IDE.Preferences Equivalent #2971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in IWorkbenchPreferenceConstants interface is deprecated and marked for removal and hence it can be replaced with public static final String PROJECT_OPEN_NEW_PERSPECTIVE = "PROJECT_OPEN_NEW_PERSPECTIVE" present in IDE.Preferences.
iloveeclipse
requested changes
May 12, 2025
| @@ -12,7 +12,8 @@ Require-Bundle: org.eclipse.core.runtime;bundle-version="[3.29.0,4.0.0)", | |||
| org.eclipse.swt;bundle-version="[3.128.0,4.0.0)";visibility:=reexport, | |||
| org.eclipse.jface;bundle-version="[3.34.0,4.0.0)";visibility:=reexport, | |||
| org.eclipse.ui.workbench;bundle-version="[3.130.0,4.0.0)";visibility:=reexport, | |||
| org.eclipse.core.expressions;bundle-version="[3.4.0,4.0.0)" | |||
| org.eclipse.core.expressions;bundle-version="[3.4.0,4.0.0)", | |||
| org.eclipse.ui.ide;bundle-version="3.22.600" | |||
There was a problem hiding this comment.
This adds cyclic dependency
There was a problem hiding this comment.
Is the presence of cyclic dependencies discouraged ?; is it okay to add the bundle requirement in the Import-Package instead?
There was a problem hiding this comment.
I don't think we would want to make an IDE-independent part depend on the IDE all of a sudden, even if it were allowed (and it's not allowed.)
There was a problem hiding this comment.
@merks Do you have any suggestions to go about this fix?
|
Maybe the deprecated addition (from 2004) should finally be removed from the preferences initializer?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PROJECT_OPEN_NEW_PERSPECTIVEconstant in the IWorkbenchPreferenceConstants interface is deprecated and marked for removal. It should be replaced with the equivalentPROJECT_OPEN_NEW_PERSPECTIVEconstant available in IDE.Preferences