Improve empty workspace helper layout #2975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adjusts the grid layout in EmptyWorkspaceHelper to address an issue in Windows with monitor specific scaling active. This commit will not fully solve the issue, but significantly lower the scenarios when it is triggered. Contributes to eclipse-platform/eclipse.platform.swt#2003
HeikoKlare
approved these changes
May 13, 2025
There was a problem hiding this comment.
Looks good, thank you! Works as expected and (almost) resolves eclipse-platform/eclipse.platform.swt#2003
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the grid layout in EmptyWorkspaceHelper to address an issue in Windows with monitor specific scaling active. This commit will not fully solve the issue, but significantly lower the scenarios when it is triggered.
It reduces the effect the mentioned issue by letting the parent Composite fill its that. That way the issue will only occur when the View has a specific width. The proper fix will need additional effort in SWT which could cause other regressions, therefor I'd recommend this PR this late in the release cycle.
Contributes to eclipse-platform/eclipse.platform.swt#2003
The Border are of course only added temporarily for the screenshots
Layout Before
Layout After