Skip to content

Migrate UI test suite to JUnit 5 and add dependencies for JUnit 5 and #2993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vogella
Copy link
Contributor

@vogella vogella commented May 19, 2025

JUnit 4 interoperability

  • Update UiTestSuite to use JUnit 5 @suite and @SelectClasses
  • Add org.junit.jupiter.api, org.junit.platform.runner, and org.junit.vintage.engine as dependencies (with and without version range) in MANIFEST.MF
  • Ensure both JUnit 5 and JUnit 4 tests can be run together
  • Modernize test infrastructure for future compatibility

JUnit 4 interoperability

- Update UiTestSuite to use JUnit 5 @suite and @SelectClasses
- Add org.junit.jupiter.api, org.junit.platform.runner, and
org.junit.vintage.engine as dependencies (with and without version
range) in MANIFEST.MF
- Ensure both JUnit 5 and JUnit 4 tests can be run together
- Modernize test infrastructure for future compatibility
Copy link
Contributor

Test Results

 1 827 files  +  3   1 827 suites  +3   1h 38m 34s ⏱️ - 3m 59s
 8 109 tests +184   7 697 ✅ ±0    412 💤 +184  0 ❌ ±0 
24 414 runs  +552  23 114 ✅ ±0  1 300 💤 +552  0 ❌ ±0 

Results for commit 6d797dd. ± Comparison against base commit 710a26a.

This pull request removes 1557 and adds 1741 tests. Note that renamed tests count towards both.
UiTestSuite org.eclipse.ui.internal.ide.ChooseWorkspaceDialogTests ‑ testFilterDuplicatedPaths
UiTestSuite org.eclipse.ui.internal.ide.DirectoryProposalContentAssistTestSuite org.eclipse.ui.internal.ide.DirectoryProposalContentAssistTest ‑ fileSeparatorOpensProposalPopup
UiTestSuite org.eclipse.ui.internal.ide.DirectoryProposalContentAssistTestSuite org.eclipse.ui.internal.ide.DirectoryProposalContentAssistTest ‑ opensProposalPopupWithSubfoldersAsProposals
UiTestSuite org.eclipse.ui.tests.StyledStringHighlighterTest ‑ testAll
UiTestSuite org.eclipse.ui.tests.StyledStringHighlighterTest ‑ testAstersisksAndEndTerminator
UiTestSuite org.eclipse.ui.tests.StyledStringHighlighterTest ‑ testAstersisksForGaps
UiTestSuite org.eclipse.ui.tests.StyledStringHighlighterTest ‑ testAstersisksForOneGap
UiTestSuite org.eclipse.ui.tests.StyledStringHighlighterTest ‑ testCapitalizedText
UiTestSuite org.eclipse.ui.tests.StyledStringHighlighterTest ‑ testCaseInsensitivity
UiTestSuite org.eclipse.ui.tests.StyledStringHighlighterTest ‑ testEndTerminator
…
DragTestSuite ‑ org.eclipse.ui.tests.dnd.Bug87211Test
DynamicPluginsTestSuite ‑ org.eclipse.ui.tests.dynamicplugins.BrowserTests
UiTestSuite ActivitiesTestSuite org.eclipse.ui.tests.activities.ActivityPreferenceTest ‑ testActivityPreference
UiTestSuite ActivitiesTestSuite org.eclipse.ui.tests.activities.DynamicTest ‑ testActivityListener
UiTestSuite ActivitiesTestSuite org.eclipse.ui.tests.activities.DynamicTest ‑ testActivityManagerListener
UiTestSuite ActivitiesTestSuite org.eclipse.ui.tests.activities.DynamicTest ‑ testActivityPatternBindings
UiTestSuite ActivitiesTestSuite org.eclipse.ui.tests.activities.DynamicTest ‑ testCategoryListener
UiTestSuite ActivitiesTestSuite org.eclipse.ui.tests.activities.DynamicTest ‑ testDynamicRegistry
UiTestSuite ActivitiesTestSuite org.eclipse.ui.tests.activities.DynamicTest ‑ testEnabledActivities
UiTestSuite ActivitiesTestSuite org.eclipse.ui.tests.activities.DynamicTest ‑ testIdentifiersListener
…
This pull request removes 95 skipped tests and adds 279 skipped tests. Note that renamed tests count towards both.
UiTestSuite org.eclipse.ui.internal.ide.DirectoryProposalContentAssistTestSuite org.eclipse.ui.internal.ide.DirectoryProposalContentAssistTest ‑ fileSeparatorOpensProposalPopup
UiTestSuite org.eclipse.ui.internal.ide.DirectoryProposalContentAssistTestSuite org.eclipse.ui.internal.ide.DirectoryProposalContentAssistTest ‑ opensProposalPopupWithSubfoldersAsProposals
UiTestSuite org.eclipse.ui.tests.activities.ActivitiesTestSuite org.eclipse.ui.tests.activities.MenusTest ‑ XXXtestMenuVisibilityWithCustomFactory
UiTestSuite org.eclipse.ui.tests.api.ApiTestSuite org.eclipse.ui.tests.api.IAggregateWorkingSetTest ‑ XXXtestWorkingSetSaveRestoreAggregates
UiTestSuite org.eclipse.ui.tests.api.ApiTestSuite org.eclipse.ui.tests.api.IDeprecatedWorkbenchPageTest ‑ XXXtestClose
UiTestSuite org.eclipse.ui.tests.api.ApiTestSuite org.eclipse.ui.tests.api.IDeprecatedWorkbenchPageTest ‑ XXXtestHideActionSet
UiTestSuite org.eclipse.ui.tests.api.ApiTestSuite org.eclipse.ui.tests.api.IDeprecatedWorkbenchPageTest ‑ XXXtestSaveAllEditors
UiTestSuite org.eclipse.ui.tests.api.ApiTestSuite org.eclipse.ui.tests.api.IDeprecatedWorkbenchPageTest ‑ XXXtestShowActionSet
UiTestSuite org.eclipse.ui.tests.api.ApiTestSuite org.eclipse.ui.tests.api.IFileEditorMappingTest ‑ testGetDefaultEditor
UiTestSuite org.eclipse.ui.tests.api.ApiTestSuite org.eclipse.ui.tests.api.IPageListenerTest ‑ testPageActivate
…
DragTestSuite ‑ org.eclipse.ui.tests.dnd.Bug87211Test
DynamicPluginsTestSuite ‑ org.eclipse.ui.tests.dynamicplugins.BrowserTests
UiTestSuite ActivitiesTestSuite org.eclipse.ui.tests.activities.MenusTest ‑ XXXtestMenuVisibilityWithCustomFactory
UiTestSuite ApiTestSuite org.eclipse.ui.tests.api.IAggregateWorkingSetTest ‑ XXXtestWorkingSetSaveRestoreAggregates
UiTestSuite ApiTestSuite org.eclipse.ui.tests.api.IDeprecatedWorkbenchPageTest ‑ XXXtestClose
UiTestSuite ApiTestSuite org.eclipse.ui.tests.api.IDeprecatedWorkbenchPageTest ‑ XXXtestHideActionSet
UiTestSuite ApiTestSuite org.eclipse.ui.tests.api.IDeprecatedWorkbenchPageTest ‑ XXXtestSaveAllEditors
UiTestSuite ApiTestSuite org.eclipse.ui.tests.api.IDeprecatedWorkbenchPageTest ‑ XXXtestShowActionSet
UiTestSuite ApiTestSuite org.eclipse.ui.tests.api.IFileEditorMappingTest ‑ testGetDefaultEditor
UiTestSuite ApiTestSuite org.eclipse.ui.tests.api.IPageListenerTest ‑ testPageActivate
…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants