Skip to content

Migrate UI test suite to JUnit 5 and add dependencies for JUnit 5 and #2993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Migrate UI test suite to JUnit 5 and add dependencies for JUnit 5 and #2993

wants to merge 2 commits into from
+9 −5

Conversation

vogella
Copy link
Contributor

@vogella vogella commented May 19, 2025

JUnit 4 interoperability

  • Update UiTestSuite to use JUnit 5 @suite and @SelectClasses
  • Add org.junit.jupiter.api, org.junit.platform.runner, and org.junit.vintage.engine as dependencies (with and without version range) in MANIFEST.MF
  • Ensure both JUnit 5 and JUnit 4 tests can be run together
  • Modernize test infrastructure for future compatibility

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 19, 2025 •
edited
Loading

Test Results

 1 827 files  + 1 827   1 827 suites  +1 827   1h 43m 47s ⏱️ + 1h 43m 47s
 8 109 tests + 8 109   7 697 ✅ + 7 697    412 💤 +  412  0 ❌ ±0 
24 414 runs  +24 414  23 114 ✅ +23 114  1 300 💤 +1 300  0 ❌ ±0 

Results for commit 2c6baef. ± Comparison against base commit 6a56d39.

♻️ This comment has been updated with latest results.

@eclipse-platform-bot @akurtakov
Migrate UI test suite to JUnit 5 and add dependencies for JUnit 5 and
7f4d2b8 
JUnit 4 interoperability

- Update UiTestSuite to use JUnit 5 @suite and @SelectClasses
- Add org.junit.jupiter.api, org.junit.platform.runner, and
org.junit.vintage.engine as dependencies (with and without version
range) in MANIFEST.MF
- Ensure both JUnit 5 and JUnit 4 tests can be run together
- Modernize test infrastructure for future compatibility
@akurtakov akurtakov force-pushed the migrate-ui-test-suite-to-junit5 branch from 6d797dd to 7f4d2b8 Compare June 6, 2025 09:15
@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

tests/org.eclipse.ui.tests/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch 
From dda3d90318aa2149ccef59e35cb7643bfc9293da Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Fri, 6 Jun 2025 09:20:22 +0000
Subject: [PATCH] Version bump(s) for 4.37 stream


diff --git a/tests/org.eclipse.ui.tests/META-INF/MANIFEST.MF b/tests/org.eclipse.ui.tests/META-INF/MANIFEST.MF
index e576d95a0a..dc7c55510a 100644
--- a/tests/org.eclipse.ui.tests/META-INF/MANIFEST.MF
+++ b/tests/org.eclipse.ui.tests/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: Eclipse UI Tests
 Bundle-SymbolicName: org.eclipse.ui.tests; singleton:=true
-Bundle-Version: 3.15.2000.qualifier
+Bundle-Version: 3.15.2100.qualifier
 Eclipse-BundleShape: dir
 Bundle-Activator: org.eclipse.ui.tests.TestPlugin
 Bundle-Vendor: Eclipse.org
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vogella @eclipse-platform-bot