Skip to content

Update test.css.core tests to Java 21 #3101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vogella
Copy link
Contributor

@vogella vogella commented Jul 10, 2025

No description provided.

@vogella vogella force-pushed the css-core-tests-java21 branch from 0584502 to bc1268a Compare July 10, 2025 08:42
@laeubi
Copy link
Contributor

laeubi commented Jul 10, 2025

@vogella please don't simply bump Java versions without any code changes, the BREE should only be incremented if it actually uses any new features as it often results in a ripple effect for consumers (not the case for tests but I think we should not do it there either "just in case".

Or is this connected to some particular issue to solve? Then you should mention it in the commit message.

@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

tests/org.eclipse.e4.ui.tests.css.core/META-INF/MANIFEST.MF

Warning

🚧 This PR cannot be modified by maintainers because edits are disabled or it is created from an organization repository. To obtain the required changes apply the git patch manually as an additional commit.

Git patch
From a31929f687e9c3d1177e62a028ed8429f08fe991 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Thu, 10 Jul 2025 08:48:28 +0000
Subject: [PATCH] Version bump(s) for 4.37 stream


diff --git a/tests/org.eclipse.e4.ui.tests.css.core/META-INF/MANIFEST.MF b/tests/org.eclipse.e4.ui.tests.css.core/META-INF/MANIFEST.MF
index 95a642165a..4b42edf477 100644
--- a/tests/org.eclipse.e4.ui.tests.css.core/META-INF/MANIFEST.MF
+++ b/tests/org.eclipse.e4.ui.tests.css.core/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Bundle-Name
 Bundle-SymbolicName: org.eclipse.e4.ui.tests.css.core
-Bundle-Version: 1.302.600.qualifier
+Bundle-Version: 1.302.700.qualifier
 Require-Bundle: org.eclipse.core.runtime,
  org.eclipse.swt,
  org.eclipse.e4.ui.css.core,
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

@vogella
Copy link
Contributor Author

vogella commented Jul 10, 2025

Yes I plan to use Java 21 features in the tests.

@laeubi
Copy link
Contributor

laeubi commented Jul 10, 2025

Yes I plan to use Java 21 features in the tests.

The please add these changes to the PR to make it a more consistent change and one can see the benefits here.

Copy link
Contributor

Test Results

 2 764 files   - 14   2 764 suites   - 14   1h 49m 41s ⏱️ + 16m 5s
 7 930 tests ± 0   7 702 ✅ ± 0  228 💤 ±0  0 ❌ ±0 
23 281 runs   - 64  22 538 ✅  - 61  743 💤  - 3  0 ❌ ±0 

Results for commit bc1268a. ± Comparison against base commit f41ea06.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants