Skip to content

Retire high contrast theme #3103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vogella
Copy link
Contributor

@vogella vogella commented Jul 10, 2025

The High Contrast theme does look very bad, it is better to retire it as this is clearly not maintained.

Fixes #3095

@jnerlich jnerlich force-pushed the retire-high-contrast-theme branch from 1941d3d to 290f910 Compare July 10, 2025 14:00
The High Contrast theme does look very bad, it is better to retire it as
this is clearly not maintained.

Fixes eclipse-platform#3095
@vogella vogella force-pushed the retire-high-contrast-theme branch from 290f910 to c7bbf1a Compare July 10, 2025 14:00
@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.ui.themes/META-INF/MANIFEST.MF

Warning

🚧 This PR cannot be modified by maintainers because edits are disabled or it is created from an organization repository. To obtain the required changes apply the git patch manually as an additional commit.

Git patch
From 422971b2daf1fde040f479343f1d3ba6c1e15e2d Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Thu, 10 Jul 2025 14:07:13 +0000
Subject: [PATCH] Version bump(s) for 4.37 stream


diff --git a/bundles/org.eclipse.ui.themes/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui.themes/META-INF/MANIFEST.MF
index 11d118fd4c..a1a0eafd86 100644
--- a/bundles/org.eclipse.ui.themes/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ui.themes/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Plugin.name
 Bundle-SymbolicName: org.eclipse.ui.themes;singleton:=true
-Bundle-Version: 1.2.2800.qualifier
+Bundle-Version: 1.2.2900.qualifier
 Bundle-Vendor: %Plugin.providerName
 Bundle-Localization: plugin
 Require-Bundle: org.eclipse.e4.ui.css.swt.theme
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

Copy link
Contributor

Test Results

 2 775 files   - 3   2 775 suites   - 3   1h 35m 41s ⏱️ + 2m 5s
 7 927 tests  - 3   7 698 ✅  -  4  228 💤 ±0  1 ❌ +1 
23 336 runs   - 9  22 589 ✅  - 10  746 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit c7bbf1a. ± Comparison against base commit f41ea06.

This pull request removes 3 tests.
org.eclipse.ui.tests.pluginchecks.PluginWalkerTest ‑ ensureExtensionPointClassesAreAccessable
org.eclipse.ui.tests.pluginchecks.PluginWalkerTest ‑ ensurePluginxmlContainsAtLeastOneEntry
org.eclipse.ui.tests.pluginchecks.PluginWalkerTest ‑ validateAccessToBundle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retire High Contrast Theme
3 participants