Skip to content

Update N&N: Clarify rationale for Cursor constructor deprecation in SWT #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2025
Merged

Update N&N: Clarify rationale for Cursor constructor deprecation in SWT #420

merged 1 commit into from
Oct 27, 2025

Conversation

@ShahzaibIbrahim
Copy link
Contributor

  • Updated the news and noteworthy entry for the deprecation of Cursor(Device, ImageData, ImageData, int, int) in SWT.
  • Clarified that the constructor was deprecated due to limited DPI support.
  • Explained that the new Cursor(Device, ImageDataProvider, int, int) constructor provides the best image for all zoom levels, ensuring proper support for high-DPI displays.

@danthe1st
Copy link
Contributor

I could be wrong but I think that platform.md is about user-visible changes and your N&N entry seems to be about an API change so I think platform_isv.md would be more appropriate.

That way, it should be accessible under "New APIs in the Platform and Equinox".
image

merks
merks requested changes Oct 6, 2025
View reviewed changes
Copy link
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in platform_isv.md

@ShahzaibIbrahim ShahzaibIbrahim force-pushed the master-2563 branch 2 times, most recently from 19a9a1f to c024dd8 Compare October 6, 2025 13:27
@ShahzaibIbrahim ShahzaibIbrahim requested a review from merks October 6, 2025 13:27
merks
merks requested changes Oct 6, 2025
View reviewed changes
Copy link
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, we're developing 4.38 not 4.37.

@ShahzaibIbrahim
Copy link
Contributor Author

@merks moved to 4.38

@ShahzaibIbrahim ShahzaibIbrahim requested a review from merks October 6, 2025 14:11
HeikoKlare
HeikoKlare reviewed Oct 6, 2025
View reviewed changes
@merks
Copy link
Contributor

merks commented Oct 6, 2025

Having read the PR it's 100% unclear to me how I would replace what I have with two arguments with a single argument. The referenced PR is completely unhelpful as a point of reference in this regard. How exactly does an image provider represent the mask and what specifically should be done?

Note the instructions

https://eclipse.dev/eclipse/markdown/?f=news/instructions.md#news-item-title-and-description

Say this:

Make the entry self-contained and mention API classes. Do not link to issues and don't promote third-party products.

Maybe an issue link would be okay if it's helpful but this is a PR and it definitely is unhelpful.

HeikoKlare
HeikoKlare reviewed Oct 7, 2025
View reviewed changes
@ShahzaibIbrahim ShahzaibIbrahim linked an issue Oct 17, 2025 that may be closed by this pull request
Add N&N entry for the deprecation of constructor in Cursor vi-eclipse/Eclipse-Platform#470
Closed
@ShahzaibIbrahim ShahzaibIbrahim force-pushed the master-2563 branch 2 times, most recently from aabcb5b to 71781c4 Compare October 17, 2025 09:05
arunjose696
arunjose696 reviewed Oct 20, 2025
View reviewed changes
@fedejeanne
Copy link
Member

@merks is the current state OK for you too?

@merks
Copy link
Contributor

merks commented Oct 22, 2025

I generally much prefer each sentence on a new line. It helps make future edits modify one short line rather than an entire paragraph.

@fedejeanne
Copy link
Member

I generally much prefer each sentence on a new line. It helps make future edits modify one short line rather than an entire paragraph.

Done

@fedejeanne
Copy link
Member

I generally much prefer each sentence on a new line. It helps make future edits modify one short line rather than an entire paragraph.

Done

@merks ?

@ShahzaibIbrahim @fedejeanne
Update N&N: Clarify rationale for Cursor constructor deprecation in SWT
a112556 
- Updated the news and noteworthy entry for the deprecation of
Cursor(Device, ImageData, ImageData, int, int)` in SWT.
- Clarified that the constructor was deprecated due to limited DPI
support.
- Explained that the new Cursor(Device, ImageDataProvider, int, int)
constructor provides the best image for all zoom levels, ensuring proper
support for high-DPI displays.
merks
merks approved these changes Oct 27, 2025
View reviewed changes
Copy link
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine now.

@fedejeanne fedejeanne merged commit f5bf2b2 into eclipse-platform:master Oct 27, 2025
1 check passed
@fedejeanne fedejeanne deleted the master-2563 branch October 27, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merks merks merks approved these changes

@fedejeanne fedejeanne fedejeanne approved these changes

@HeikoKlare HeikoKlare Awaiting requested review from HeikoKlare

+1 more reviewer

@arunjose696 arunjose696 arunjose696 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add N&N entry for the deprecation of constructor in Cursor

6 participants

@ShahzaibIbrahim @danthe1st @merks @fedejeanne @HeikoKlare @arunjose696