Skip to content

Conversation

@elsazac
Copy link
Member

@elsazac elsazac commented Nov 3, 2025

This PR adds N&N entry for PR's 3433, 2120, 2188 and 2118

@elsazac elsazac force-pushed the filteringoptionsinN&N branch 2 times, most recently from 0c00780 to fa33d4a Compare November 3, 2025 12:57
@elsazac
Copy link
Member Author

elsazac commented Nov 3, 2025

@merks Could you check if this looks okay?

@elsazac elsazac force-pushed the filteringoptionsinN&N branch 4 times, most recently from 286a571 to f431661 Compare November 4, 2025 07:18
Copy link
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to mark it to request changes.

Are you actually previewing the content and comparing how it looks to existing content?

https://eclipse.dev/eclipse/markdown/?f=news/instructions.md#markdown-preview

@elsazac elsazac force-pushed the filteringoptionsinN&N branch 2 times, most recently from 054379b to e563f44 Compare November 4, 2025 09:54
Copy link
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if you really intend every sentence to be a separate paragraph? Two sentences on separate lines without a blank line between then will become part of a single paragraph. It seems to me originally you had several sentences in one huge line to create paragraph. So I want to be sure you intended there to be so many paragraphs?

@elsazac
Copy link
Member Author

elsazac commented Nov 4, 2025

I'm not sure if you really intend every sentence to be a separate paragraph? Two sentences on separate lines without a blank line between then will become part of a single paragraph. It seems to me originally you had several sentences in one huge line to create paragraph. So I want to be sure you intended there to be so many paragraphs?

I wanted only 3 paragraphs initially, with the middle one being about the actual feature.
I got confused on how to break it to parts so that it still looks meaningful to the readers.
But I have made a bit of change now. Hope that looks okay

@elsazac elsazac force-pushed the filteringoptionsinN&N branch 4 times, most recently from afeaf3c to f4ea788 Compare November 4, 2025 10:32
@elsazac elsazac force-pushed the filteringoptionsinN&N branch 2 times, most recently from da2b38b to ad9110e Compare November 5, 2025 07:17
@elsazac elsazac force-pushed the filteringoptionsinN&N branch from ad9110e to 5a8b8de Compare November 5, 2025 12:14
Added a N&N entry about the new filtering options available in Template
and File Content preference pages.
@elsazac elsazac force-pushed the filteringoptionsinN&N branch from 5a8b8de to 13f04b3 Compare November 5, 2025 12:14
@elsazac
Copy link
Member Author

elsazac commented Nov 6, 2025

@merks could you approve this?

Copy link
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your patience and for the changes which look good!

@merks merks merged commit f6273b7 into eclipse-platform:master Nov 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants