Skip to content

Conversation

@fx-world
Copy link
Contributor

I have no idea why the commit is "mknauer authored", that was not the case.

Also-by: Ralf Schlesinger [email protected]
Also-by: Rico Scholz [email protected]

@eclipse-rap-bot
Copy link

Can one of the admins verify this patch?

@ifurnadjiev
Copy link
Contributor

ok to test

@ifurnadjiev
Copy link
Contributor

It's better to implement it in PropertyResolver.readFontSize(LexicalUnit) instead of PropertyResolver.readSingleLengthUnit.
PropertyResolver.readSingleLengthUnit is used in other places like readDimension or readShadow, where pt does not make sense. Please add a test to org.eclipse.rap.rwt.internal.theme.css.PropertyResolver_Test.testFontSize().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants