rust: replace std queue with baselibs rust #124
+25
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelrutkaq
requested review from
LittleHuba,
castler and
hoe-jo
as code owners
pawelrutkaq
force-pushed
the
pawelrutkaq_use_baselib_queue
branch
2 times, most recently
from
b8e5b62 to
52264b5
Compare
darkwisebear
approved these changes
Dec 18, 2025
| ], | ||
| deps = [], | ||
| deps = [ | ||
| "@score_baselibs_rust//src/containers:containers", |
Contributor
There was a problem hiding this comment.
Why is there a split between baselibs and baselibs_rust?
Contributor
Author
Contributor
There was a problem hiding this comment.
I'd like to understand the reasons for that. Any decision records on this?
pawelrutkaq
force-pushed
the
pawelrutkaq_use_baselib_queue
branch
from
52264b5 to
bf107c4
Compare
Contributor
Author
|
@LittleHuba can we move that into copybara sync ? |
pawelrutkaq
force-pushed
the
pawelrutkaq_use_baselib_queue
branch
from
bf107c4 to
15e7409
Compare
pawelrutkaq
force-pushed
the
pawelrutkaq_use_baselib_queue
branch
from
15e7409 to
a4cf733
Compare
Contributor
Author
|
@LittleHuba kind reminder |
pawelrutkaq
force-pushed
the
pawelrutkaq_use_baselib_queue
branch
from
a4cf733 to
0604f7d
Compare
pawelrutkaq
force-pushed
the
pawelrutkaq_use_baselib_queue
branch
from
0604f7d to
03148db
Compare
LittleHuba
added
the
import-started-do-not-modify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.