Skip to content

Feat/generate sn6 schema validation #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
arnoox wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Feat/generate sn6 schema validation #394

arnoox wants to merge 12 commits into from

Conversation

@arnoox
Copy link
Contributor

@arnoox arnoox commented Feb 6, 2026 •
edited
Loading

📌 Description

🚨 Impact Analysis

  • This change does not violate any tool requirements and is covered by existing tool requirements
  • This change does not violate any design decisions
  • Otherwise I have created a ticket for new tool qualification

✅ Checklist

  • Added/updated documentation for new or changed features
  • Added/updated tests to cover the changes
  • Followed project coding standards and guidelines

@github-actions
Copy link

github-actions bot commented Feb 6, 2026 •
edited
Loading

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //src:license-check

Status: ⚠️ Needs Review

Click to expand output 
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 6e309737-d5c8-431a-b381-8947a8aa6e4f
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: src
Loading: 0 packages loaded
    currently loading: src
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //src:license-check (60 packages loaded, 9 targets configured)

Analyzing: target //src:license-check (71 packages loaded, 9 targets configured)

Analyzing: target //src:license-check (118 packages loaded, 417 targets configured)

Analyzing: target //src:license-check (128 packages loaded, 2113 targets configured)

Analyzing: target //src:license-check (136 packages loaded, 2539 targets configured)

Analyzing: target //src:license-check (140 packages loaded, 2576 targets configured)

Analyzing: target //src:license-check (140 packages loaded, 2576 targets configured)

Analyzing: target //src:license-check (140 packages loaded, 2576 targets configured)

Analyzing: target //src:license-check (144 packages loaded, 4589 targets configured)

INFO: Analyzed target //src:license-check (145 packages loaded, 4715 targets configured).
[14 / 16] [Prepa] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar
[15 / 16] Building src/license.check.license_check.jar (); 0s disk-cache, multiplex-worker
INFO: Found 1 target...
Target //src:license.check.license_check up-to-date:
  bazel-bin/src/license.check.license_check
  bazel-bin/src/license.check.license_check.jar
INFO: Elapsed time: 21.897s, Critical Path: 2.63s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/src/license.check.license_check src/formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions
Copy link

github-actions bot commented Feb 6, 2026

The created documentation from the pull request is available at: docu-html

ubmarco
ubmarco suggested changes Feb 6, 2026
View reviewed changes
Copy link
Contributor

@ubmarco ubmarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing a test for this. Ideally the generated schema.json is tested against the same SCORE metamodel tests. Then we can be sure the migration was successful.

src/extensions/score_metamodel/metamodel.yaml Outdated
# req-Id: tool_req__docs_common_attr_status
status: ^(valid|draft)$
content: ^[\s\S]+$
content: ^(.|[\n\r])+$
Copy link
Contributor

@ubmarco ubmarco Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check whether these regexes make any trouble in SN6.
Maybe they work in jsonschema-rs. I changed those before we did the migration from jsonschema to jsonschema-rs.

Copy link
Contributor Author

@arnoox arnoox Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-introduced the original regex string, which runs as expected.

src/extensions/score_metamodel/sn_schemas.py Outdated
Schema structure per need type (sphinx-needs schema format):
- ``select`` : matches needs by their ``type`` field
- ``validate.local`` : validates the need's own properties (patterns, required)
- ``validate.network`` : validates properties of linked needs (NOT YET ACTIVE)
Copy link
Contributor

@ubmarco ubmarco Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is network not yet active? Is that a thing for another PR?

Copy link
Contributor Author

@arnoox arnoox Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I Just feared this is too big. Looking into it right now. Change size seems to be acceptable, so I'll include it in this PR.

Copy link
Contributor Author

@arnoox arnoox Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@arnoox
Copy link
Contributor Author

arnoox commented Feb 9, 2026

Thanks for the review!

I'm missing a test for this. Ideally the generated schema.json is tested against the same SCORE metamodel tests. Then we can be sure the migration was successful.

Yeah this was still work in progress. I introduced a refactored/more testable version of the sn_schemas transformation, including unit/integration tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexanderLanin AlexanderLanin Awaiting requested review from AlexanderLanin AlexanderLanin will be requested when the pull request is marked ready for review AlexanderLanin is a code owner

@MaximilianSoerenPollak MaximilianSoerenPollak Awaiting requested review from MaximilianSoerenPollak MaximilianSoerenPollak will be requested when the pull request is marked ready for review MaximilianSoerenPollak is a code owner

@dcalavrezo-qorix dcalavrezo-qorix Awaiting requested review from dcalavrezo-qorix dcalavrezo-qorix will be requested when the pull request is marked ready for review dcalavrezo-qorix is a code owner

@nradakovic nradakovic Awaiting requested review from nradakovic nradakovic will be requested when the pull request is marked ready for review nradakovic is a code owner

1 more reviewer

@ubmarco ubmarco ubmarco requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

INF - Infrastructure Community
Status: Draft

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arnoox @ubmarco