fix: raise clear error when ping utility is missing#64
Merged
Conversation
Previously, if the system ping binary was not installed, os.system()
returned exit code 127 (shell command not found), which was silently
treated as a failed ping attempt. This caused a misleading assertion
failure like "Target is not pingable within expected time frame"
instead of indicating that ping itself is missing.
Fix by checking shutil.which("ping") before invoking the binary and
raising a RuntimeError with an actionable message if it is absent.
Add unit tests covering the missing-binary error, reachable host,
and unreachable host cases.
Closes #63
ltekieli
force-pushed
the
lt_itf_missing_ping_error
branch
from
5c7c340 to
bc4dcd8
Compare
antonkri
approved these changes
Mar 6, 2026
github-project-automation
bot
moved this from Backlog
to Done
in TST - Testing Community
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if the system ping binary was not installed, os.system() returned exit code 127 (shell command not found), which was silently treated as a failed ping attempt. This caused a misleading assertion failure like "Target is not pingable within expected time frame" instead of indicating that ping itself is missing.
Fix by checking shutil.which("ping") before invoking the binary and raising a RuntimeError with an actionable message if it is absent.
Add unit tests covering the missing-binary error, reachable host, and unreachable host cases.
Closes #63