hmon: add positive path unit tests for HMON FFI by arkjedrz · Pull Request #83 · eclipse-score/lifecycle

arkjedrz · 2026-02-18T13:10:22Z

Only positive path is tested.
Negative path will require rework to avoid aborts.

github-actions · 2026-02-18T13:11:16Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.4.2) and connecting to it...
INFO: Invocation ID: f604f3bf-a701-4324-be3f-d48ac78162dc
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'rules_python', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_cc', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'aspect_rules_lint', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'download_utils', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'googletest', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_rust_policies', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (49 packages loaded, 9 targets configured)

Analyzing: target //:license-check (130 packages loaded, 433 targets configured)

Analyzing: target //:license-check (148 packages loaded, 3134 targets configured)

Analyzing: target //:license-check (148 packages loaded, 5805 targets configured)

Analyzing: target //:license-check (160 packages loaded, 7817 targets configured)

Analyzing: target //:license-check (160 packages loaded, 7817 targets configured)

Analyzing: target //:license-check (160 packages loaded, 7817 targets configured)

Analyzing: target //:license-check (161 packages loaded, 7941 targets configured)

INFO: Analyzed target //:license-check (165 packages loaded, 9955 targets configured).
[10 / 16] [Prepa] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes ... (2 actions, 1 running)
[13 / 16] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox
[14 / 16] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 24.341s, Critical Path: 2.78s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

github-actions · 2026-02-18T13:13:14Z

The created documentation from the pull request is available at: docu-html

Copilot

Pull request overview

This PR adds positive path unit tests for the Health Monitor FFI (Foreign Function Interface) layer. These tests verify that the C-compatible FFI functions work correctly for successful code paths. The tests cover builder creation, destruction, deadline monitor addition, health monitor building, deadline monitor retrieval, starting the health monitor, and resource cleanup.

Changes:

Added 7 unit tests covering positive paths for all HMON FFI functions
Tests verify handle creation, manipulation, and basic cleanup operations
Negative path testing is deferred due to abort behavior in error cases

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/health_monitoring_lib/rust/ffi.rs

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-18T14:03:29Z

src/health_monitoring_lib/rust/ffi.rs

+    fn test_health_monitor_builder_add_deadline_monitor_ok() {
+        let health_monitor_builder_handle = health_monitor_builder_create();


Test names in this repo appear to use descriptive snake_case without a test_ prefix or _ok suffix. Consider renaming this test accordingly to match existing conventions.

Copilot · 2026-02-18T14:03:30Z

src/health_monitoring_lib/rust/ffi.rs

+    fn test_health_monitor_builder_build_ok() {
+        let health_monitor_builder_handle = health_monitor_builder_create();


Test names in this repo appear to use descriptive snake_case without a test_ prefix or _ok suffix. Consider renaming this test accordingly to match existing conventions.

Copilot · 2026-02-18T14:03:30Z

src/health_monitoring_lib/rust/ffi.rs

+    fn test_health_monitor_get_deadline_monitor_ok() {
+        let health_monitor_builder_handle = health_monitor_builder_create();


Test names in this repo appear to use descriptive snake_case without a test_ prefix or _ok suffix. Consider renaming this test accordingly to match existing conventions.

Copilot · 2026-02-18T14:03:30Z

src/health_monitoring_lib/rust/ffi.rs

+    fn test_health_monitor_start_ok() {
+        let health_monitor_builder_handle = health_monitor_builder_create();


Test names in this repo appear to use descriptive snake_case without a test_ prefix or _ok suffix. Consider renaming this test accordingly to match existing conventions.

Copilot · 2026-02-18T14:03:30Z

src/health_monitoring_lib/rust/ffi.rs

+        let health_monitor_builder_handle = health_monitor_builder_create();
+        let deadline_monitor_tag = IdentTag::new("deadline_monitor");
+        let deadline_monitor_builder_handle = deadline_monitor_builder_create();
+        health_monitor_builder_add_deadline_monitor(
+            health_monitor_builder_handle,
+            &deadline_monitor_tag as *const IdentTag,
+            deadline_monitor_builder_handle,
+        );
+        let health_monitor_handle = health_monitor_builder_build(health_monitor_builder_handle, 200, 100);


These tests repeat the same FFI setup/teardown pattern (create builder, add deadline monitor, build, optionally get deadline monitor). Consider extracting a small helper (or RAII wrapper) to reduce duplication and make cleanup rules for consumed handles harder to get wrong as more cases are added.

pawelrutkaq · 2026-02-19T11:04:05Z

src/health_monitoring_lib/rust/ffi.rs

+    use crate::IdentTag;
+
+    #[test]
+    fn test_health_monitor_builder_create_ok() {


remove test_ prefix

Only positive path is tested. Negative path will require rework to avoid aborts.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-19T11:41:53Z

src/health_monitoring_lib/rust/ffi.rs

+        let health_monitor_builder_handle = health_monitor_builder_create();
+        let health_monitor_handle = health_monitor_builder_build(health_monitor_builder_handle, 200, 100);
+        assert!(!health_monitor_handle.is_null());


The build calls repeat magic numbers for cycle durations (e.g., 200 and 100). Consider introducing local constants (e.g., SUPERVISOR_CYCLE_MS, INTERNAL_CYCLE_MS) so the units/intent are clearer and changes only need to be made in one place.

Copilot · 2026-02-19T11:41:54Z

src/health_monitoring_lib/rust/ffi.rs

+    #[test]
+    fn health_monitor_start_ok() {
+        let health_monitor_builder_handle = health_monitor_builder_create();
+        let deadline_monitor_tag = IdentTag::new("deadline_monitor");
+        let deadline_monitor_builder_handle = deadline_monitor_builder_create();
+        health_monitor_builder_add_deadline_monitor(
+            health_monitor_builder_handle,
+            &deadline_monitor_tag as *const IdentTag,
+            deadline_monitor_builder_handle,
+        );
+        let health_monitor_handle = health_monitor_builder_build(health_monitor_builder_handle, 200, 100);
+
+        let deadline_monitor_handle =
+            health_monitor_get_deadline_monitor(health_monitor_handle, &deadline_monitor_tag as *const IdentTag);
+        assert!(!deadline_monitor_handle.is_null());
+
+        health_monitor_start(health_monitor_handle);
+
+        // Clean-up.
+        deadline_monitor_cpp_destroy(deadline_monitor_handle);
+        health_monitor_destroy(health_monitor_handle);


health_monitor_start_ok starts a background thread; the subsequent destroy/join can block for up to internal_cycle_ms because the worker may be sleeping. To keep the unit test suite fast and reduce timing sensitivity, consider using much smaller cycle values here (still respecting the multiple-of invariant).

arkjedrz requested review from Copilot and pawelrutkaq February 18, 2026 13:10

arkjedrz self-assigned this Feb 18, 2026

arkjedrz temporarily deployed to workflow-approval February 18, 2026 13:10 — with GitHub Actions Inactive

Copilot started reviewing on behalf of arkjedrz February 18, 2026 13:10 View session

Copilot AI reviewed Feb 18, 2026

View reviewed changes

arkjedrz force-pushed the arkjedrz_add-hmon-ffi-unit-tests branch from c4f40a1 to f9f7448 Compare February 18, 2026 13:29

arkjedrz had a problem deploying to workflow-approval February 18, 2026 13:29 — with GitHub Actions Error

arkjedrz had a problem deploying to workflow-approval February 18, 2026 13:29 — with GitHub Actions Failure

arkjedrz force-pushed the arkjedrz_add-hmon-ffi-unit-tests branch from f9f7448 to e985288 Compare February 18, 2026 13:41

arkjedrz temporarily deployed to workflow-approval February 18, 2026 13:41 — with GitHub Actions Inactive

arkjedrz mentioned this pull request Feb 18, 2026

fix paths in reusable workflow eclipse-score/reference_integration#105

Merged

arkjedrz force-pushed the arkjedrz_add-hmon-ffi-unit-tests branch from e985288 to 6ef7f1d Compare February 18, 2026 13:53

arkjedrz temporarily deployed to workflow-approval February 18, 2026 13:53 — with GitHub Actions Inactive

arkjedrz requested a review from Copilot February 18, 2026 13:58

Copilot started reviewing on behalf of arkjedrz February 18, 2026 13:59 View session

Copilot AI reviewed Feb 18, 2026

View reviewed changes

arkjedrz force-pushed the arkjedrz_add-hmon-ffi-unit-tests branch from 6ef7f1d to f41385b Compare February 19, 2026 09:55

arkjedrz temporarily deployed to workflow-approval February 19, 2026 09:55 — with GitHub Actions Inactive

pawelrutkaq requested changes Feb 19, 2026

View reviewed changes

hmon: add positive path unit tests for HMON FFI

ab9e0e8

Only positive path is tested. Negative path will require rework to avoid aborts.

arkjedrz force-pushed the arkjedrz_add-hmon-ffi-unit-tests branch from f41385b to ab9e0e8 Compare February 19, 2026 11:33

arkjedrz temporarily deployed to workflow-approval February 19, 2026 11:33 — with GitHub Actions Inactive

arkjedrz requested review from Copilot and pawelrutkaq February 19, 2026 11:37

Copilot started reviewing on behalf of arkjedrz February 19, 2026 11:38 View session

pawelrutkaq approved these changes Feb 19, 2026

View reviewed changes

pawelrutkaq merged commit 997ffa1 into eclipse-score:main Feb 19, 2026
18 checks passed

Copilot AI reviewed Feb 19, 2026

View reviewed changes

arkjedrz deleted the arkjedrz_add-hmon-ffi-unit-tests branch February 19, 2026 12:17

		fn test_health_monitor_builder_add_deadline_monitor_ok() {
		let health_monitor_builder_handle = health_monitor_builder_create();

		fn test_health_monitor_builder_build_ok() {
		let health_monitor_builder_handle = health_monitor_builder_create();

		fn test_health_monitor_get_deadline_monitor_ok() {
		let health_monitor_builder_handle = health_monitor_builder_create();

		fn test_health_monitor_start_ok() {
		let health_monitor_builder_handle = health_monitor_builder_create();

Conversation

arkjedrz commented Feb 18, 2026

Uh oh!

github-actions bot commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

github-actions bot commented Feb 18, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

pawelrutkaq Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

github-actions bot commented Feb 18, 2026 •

edited

Loading