Draft
Conversation
Member
ltekieli
commented
Mar 6, 2026
- Update score_itf to 44c75de and score_bazel_platforms to b72a5c3 in known_good.json and MODULE.bazel overrides
- Add explicit bazel_dep on platforms 1.0.0 (required by new config_settings)
- Merge the two py_itf_test targets (linux_x86_64, qnx_x86_64) in feature_integration_tests/itf/BUILD into a single 'itf' target that uses config_setting + select() to switch args/data/plugins per platform; keep backward-compatible aliases for the old target names
- Upgrade rules_oci from 1.8.0 to 2.2.7; adapt images/linux_x86_64/BUILD to use oci_load (replacing the removed oci_tarball) and add the platform-specific ubuntu_22_04_linux_amd64 repo
8a6ac2b to
914ec16
Compare
|
The created documentation from the pull request is available at: docu-html |
914ec16 to
f90169f
Compare
pawelrutkaq
requested changes
Mar 6, 2026
| srcs = ["//runners/docker_x86_64/scripts:run_docker.sh"], | ||
| args = [ | ||
| "$(location :image_tarball)", | ||
| "$(location :image_load)", |
Contributor
There was a problem hiding this comment.
this change breaks ./score_start
Member
Author
There was a problem hiding this comment.
There's an open issue: bazel-contrib/rules_oci#874
| tag = "stream10", | ||
| ) | ||
| use_repo(oci, "centos_stream10", "ubuntu_22_04") | ||
| use_repo(oci, "centos_stream10", "centos_stream10_linux_amd64") |
Contributor
There was a problem hiding this comment.
@odra which image shall be used centos_stream10 or entos_stream10_linux_amd64?
- Update score_itf to 44c75de and score_bazel_platforms to b72a5c3 in known_good.json and MODULE.bazel overrides - Add explicit bazel_dep on platforms 1.0.0 (required by new config_settings) - Merge the two py_itf_test targets (linux_x86_64, qnx_x86_64) in feature_integration_tests/itf/BUILD into a single 'itf' target that uses config_setting + select() to switch args/data/plugins per platform; keep backward-compatible aliases for the old target names - Upgrade rules_oci from 1.8.0 to 2.2.7; adapt images/linux_x86_64/BUILD to use oci_load (replacing the removed oci_tarball) and add the platform-specific ubuntu_22_04_linux_amd64 repo
f90169f to
28b936d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.