Skip to content

Use py_itf_test rule with select support#177

Draft
ltekieli wants to merge 1 commit intomainfrom
lt_itf_rule_support
Draft

Use py_itf_test rule with select support#177
ltekieli wants to merge 1 commit intomainfrom
lt_itf_rule_support

Conversation

@ltekieli
Copy link
Member

@ltekieli ltekieli commented Mar 6, 2026

  • Update score_itf to 44c75de and score_bazel_platforms to b72a5c3 in known_good.json and MODULE.bazel overrides
  • Add explicit bazel_dep on platforms 1.0.0 (required by new config_settings)
  • Merge the two py_itf_test targets (linux_x86_64, qnx_x86_64) in feature_integration_tests/itf/BUILD into a single 'itf' target that uses config_setting + select() to switch args/data/plugins per platform; keep backward-compatible aliases for the old target names
  • Upgrade rules_oci from 1.8.0 to 2.2.7; adapt images/linux_x86_64/BUILD to use oci_load (replacing the removed oci_tarball) and add the platform-specific ubuntu_22_04_linux_amd64 repo

@ltekieli ltekieli force-pushed the lt_itf_rule_support branch 3 times, most recently from 8a6ac2b to 914ec16 Compare March 6, 2026 14:13
@github-actions
Copy link

github-actions bot commented Mar 6, 2026

The created documentation from the pull request is available at: docu-html

@ltekieli ltekieli force-pushed the lt_itf_rule_support branch from 914ec16 to f90169f Compare March 6, 2026 14:24
Copy link
Contributor

@pawelrutkaq pawelrutkaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some issues

srcs = ["//runners/docker_x86_64/scripts:run_docker.sh"],
args = [
"$(location :image_tarball)",
"$(location :image_load)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change breaks ./score_start

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an open issue: bazel-contrib/rules_oci#874

tag = "stream10",
)
use_repo(oci, "centos_stream10", "ubuntu_22_04")
use_repo(oci, "centos_stream10", "centos_stream10_linux_amd64")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@odra which image shall be used centos_stream10 or entos_stream10_linux_amd64?

- Update score_itf to 44c75de and score_bazel_platforms to b72a5c3 in
  known_good.json and MODULE.bazel overrides
- Add explicit bazel_dep on platforms 1.0.0 (required by new config_settings)
- Merge the two py_itf_test targets (linux_x86_64, qnx_x86_64) in
  feature_integration_tests/itf/BUILD into a single 'itf' target that uses
  config_setting + select() to switch args/data/plugins per platform;
  keep backward-compatible aliases for the old target names
- Upgrade rules_oci from 1.8.0 to 2.2.7; adapt images/linux_x86_64/BUILD
  to use oci_load (replacing the removed oci_tarball) and add the
  platform-specific ubuntu_22_04_linux_amd64 repo
@ltekieli ltekieli force-pushed the lt_itf_rule_support branch from f90169f to 28b936d Compare March 6, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants