Bugfix parsing control transfer requests

[SeanHowsonAdvCo]

Hi Folks,

I've been porting a product over to USBX from a previous driver & noticed what i'm fairly confident is a small error in the function "_ux_device_stack_control_request_process"

An if statement toward the top of the function evaluates the request type being sent by the host to determine if it is something other than a standard request (class or vendor).

But the statement evaluates "request_value", which usually contains information specific/contextual to each request.
The request type is stored in bits 6 & 7 of bmRequestType & as far as i can see this is stored in request_type...

Several other statements below evaluate what i believe to be the correct variable.

I've modified the file & added a note to the top too. This is actually the first time I've contributed to an open-source project! So apologies in advance if i've missed anything, i've tried to pattern match things like branch-names etc, it seemed most of the bug-fix type PR's i could see were being merged to the dev branch, but if there's anything that needs tweaking let me know.

Best regards
Sean

P.S. If it turns out i'm mistaken, no offence will be taken to a declined PR!

[SeanHowsonAdvCo]

...currently working on the failed check! Appreciate you folks could probably just raise a parallel PR and sort the issue, but i'm keen to contribute here... IOW, please bear with me!

[fdesbiens]

Hi @SeanHowsonAdvCo.

Thank you for this contribution!

Before we can accept it, you need to sign the Eclipse Contributor Agreement (ECA). The purpose of the ECA is to provide a written record that you have agreed to provide your code and documentation contributions under the licenses used by the Eclipse ThreadX project. It also makes it clear that you are promising that what you are contributing to Eclipse is code you wrote, and you have the necessary rights to contribute it to our projects. And finally, it documents a commitment from you that your open source contributions will be permanently on the public record.

Signing the ECA requires an Eclipse Foundation account if you do not already have one. You can create one for free at https://accounts.eclipse.org.

Be sure to use the same email address when you register for the account that you intend to use on Git commit records.

Here is the link to sign the ECA:
https://accounts.eclipse.org/user/login?destination=user/eca

[fdesbiens]

Once you sort this out, @SeanHowsonAdvCo, I will ask a team member to review the PR.

If it passes muster, I will merge to dev, and this should ship with our Q4 2025 release.

[SeanHowsonAdvCo]

Once you sort this out, @SeanHowsonAdvCo, I will ask a team member to review the PR.

If it passes muster, I will merge to dev, and this should ship with our Q4 2025 release.

Hey! Thanks for the quick response, yep, i'm sorting the agreement now (like i say, first time i've done this!). Thanks for the guidance above too.

Hopefully it measures up! But if i am simply mistaken... then that's good all the same!

[SeanHowsonAdvCo]

@fdesbiens sorted! (turns out if you press the same button enough times, it just works)

[fdesbiens]

@SeanHowsonAdvCo I just forced the check to run. All is good. Assigning a knowledgeable committer to review now.

[SeanHowsonAdvCo]

@SeanHowsonAdvCo I just forced the check to run. All is good. Assigning a knowledgeable committer to review now.

Ha, i did think just pressing the same button again and getting a different result seemed a bit odd! Thanks! :)