Adding exception type for empty callback functions#301
Closed
gregmedd wants to merge 4 commits intoeclipse-uprotocol:v1.0_up-v1.6.0from
Closed
Adding exception type for empty callback functions#301gregmedd wants to merge 4 commits intoeclipse-uprotocol:v1.0_up-v1.6.0from
gregmedd wants to merge 4 commits intoeclipse-uprotocol:v1.0_up-v1.6.0from
Conversation
This exception will be thrown when an empty std::function is passed to the callback connection module. Adding the type first so that tests can be written.
|
Code coverage report is ready! 📈
|
|
Code coverage report is ready! 📈
|
Some L2 tests were asserting that the std::bad_function_call exception should be thrown when a bad callback is called. We will be changing that behavior so that the exception is thrown when the callback connection is established, requiring updated test cases.
The CalleeHandle class is the "owner" of the callback function objects associated with a callback connection. As such, it will check the validity of those function objects and throw the EmptyFunctionObject exception if either the callback or cleanup function is empty / invalid.
|
Code coverage report is ready! 📈
|
gregmedd
requested review from
PLeVasseur,
agosh01,
billpittman and
stevenhartley
|
Code coverage report is ready! 📈
|
PLeVasseur
added a commit
that referenced
this pull request
Mar 7, 2025
) (#304) * Adding exception type for empty callback functions This exception will be thrown when an empty std::function is passed to the callback connection module. Adding the type first so that tests can be written. * Add callback tests for empty function objects * Fix null callback assertions in L2 tests Some L2 tests were asserting that the std::bad_function_call exception should be thrown when a bad callback is called. We will be changing that behavior so that the exception is thrown when the callback connection is established, requiring updated test cases. * Add empty function checks in CalleeHandle The CalleeHandle class is the "owner" of the callback function objects associated with a callback connection. As such, it will check the validity of those function objects and throw the EmptyFunctionObject exception if either the callback or cleanup function is empty / invalid. * Update include/up-cpp/utils/CallbackConnection.h Co-authored-by: Pete LeVasseur <[email protected]> * specify Clang version 17 in CI --------- Co-authored-by: Greg Medding <[email protected]> Co-authored-by: Pete LeVasseur <[email protected]>
Contributor
|
Closing as duplicate of the now-merged #304 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This exception will be thrown when an empty std::function is passed to the callback connection module. Adding the type first so that tests can be written.
closes #194