Skip to content

Conversation

@MaximilianToe
Copy link
Contributor

@MaximilianToe MaximilianToe commented Jul 25, 2025

This PR changes the way the method Uuri is passed to the RpcClient. It is now passed when calling InvokeMethod instead of when building the client. This allows the user to reuse a single RpcClient instance for multiple methods.

Closes #325

@github-actions
Copy link

Code coverage report is ready! 📈

Copy link
Contributor

@PLeVasseur PLeVasseur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MaximilianToe! The way you approached it makes sense to me.

Was wondering if you've added tests which would test the new case of an invalid method being passed into invokeMethod(). I looked through a bit, but didn't find it. 😅

@MaximilianToe
Copy link
Contributor Author

Thanks @MaximilianToe! The way you approached it makes sense to me.

Was wondering if you've added tests which would test the new case of an invalid method being passed into invokeMethod(). I looked through a bit, but didn't find it. 😅

Ah, I forgot to write a new test for the new case. Will add this to this PR.

@PLeVasseur
Copy link
Contributor

Ah, I forgot to write a new test for the new case. Will add this to this PR.

Gotcha, thanks for checking my eyesight 👓

@github-actions
Copy link

Code coverage report is ready! 📈

Copy link
Contributor

@PLeVasseur PLeVasseur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these additional tests @MaximilianToe!

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rework the way RpcClient receives the method uuri

2 participants