-
Notifications
You must be signed in to change notification settings - Fork 33
changed RpcClient signature to use method UUri only when calling #326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed RpcClient signature to use method UUri only when calling #326
Conversation
|
Code coverage report is ready! 📈
|
PLeVasseur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MaximilianToe! The way you approached it makes sense to me.
Was wondering if you've added tests which would test the new case of an invalid method being passed into invokeMethod(). I looked through a bit, but didn't find it. 😅
Ah, I forgot to write a new test for the new case. Will add this to this PR. |
Gotcha, thanks for checking my eyesight 👓 |
|
Code coverage report is ready! 📈
|
PLeVasseur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding these additional tests @MaximilianToe!
LGTM
This PR changes the way the method Uuri is passed to the RpcClient. It is now passed when calling InvokeMethod instead of when building the client. This allows the user to reuse a single RpcClient instance for multiple methods.
Closes #325