-
Notifications
You must be signed in to change notification settings - Fork 16
added spec version and compliance check badge #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hey @Xerner, this is a nice idea and should work for information that we only ever need to determine for the HEAD revision of the main branch. However, my understanding is that all revisions of our README.md file (in the up-rust repo) will always refer to the same badge definition file in the gist repo, and thus they will all indicate the same (latest) version of up-spec, or am I mistaken? If so, this would mean that if I go to an older tag in the up-rust repo, the README.md would still contain a badge that would indicate the crate implementing the most recent version of up-spec, right? |
Correct. If we wish to track historical up-spec version compatability badges when looking at past revisions, then the github action would have to commit a change directly in the README.md file to update the badge. No Gist would be used, and the badge would be a static image link. It would mean adding a commit every time the up-spec submodule changes its referenced commit. I see no issue with this |
|
One thing that I wonder - without having looked at the details of this PR, I will do that asap - might this information (supported-spec-version) be a good datum to go into its own little text file, top-level of the repo? I'm thinking of a few use cases we could build on this, more easily than if the information was directly buried in the README:
|
|
Converting this into a draft until a decision is made on exactly how the badge should be applied to the README.md file. Currently known strategies for applying a status badge are
|
|
Hi @Xerner, we already have a (reusable) GitHub workflow that checks compliance with the current/latest spec. You can refer to the nightly.yaml workflow definition for details. |
Specifically, as we were chatting about in the meeting the workflow can be found here: |
|
Note: this PR was previously named "added spec compliance check badge" but actually just added a check for the latest spec version. So, I just added an additional badge that checks up-spec compliance and renamed the PR accordingly. Might as well have both, right?
I switched my implementation from using a Github Gist to directly pushing a commit to the repo from the Github Action run. The PR is failing because the commit is authored by |

This PR adds a workflow that adds badges that show
The actual implementation and one-time steps necessary for this to work are located here eclipse-uprotocol/ci-cd#23
addresses #282