Update Feature Files and Test Agents to 1.5.8#80
Draft
matthewd0123 wants to merge 32 commits intoeclipse-uprotocol:mainfrom
Draft
Update Feature Files and Test Agents to 1.5.8#80matthewd0123 wants to merge 32 commits intoeclipse-uprotocol:mainfrom
matthewd0123 wants to merge 32 commits intoeclipse-uprotocol:mainfrom
Conversation
* Align UriValidator test with v1.5.8 * Update Python and Java TAs to work with UriValidator * Create skeleton for 1.5.8 version of SocketUTransports in Python and Java (still requires work after this PR) * Update Test Manager port (was causing issues locally, changing it fixed the issue) * Remove some deprecated code from Python and Java Test Agents
* Align UUIDValidator test with v1.5.8
* Update UAttributesValidator Feature file to 1.5.8 * Update Python Test Agent to align with 1.5.8
* Remove Long and Micro URI references in code * Add new UriSerializer and UriDeserializer feature files for 1.5.8 * Update python and java to align to uriserializer and deserializer for 1.5.8
Since up-java doesn't use is_notification_destination, this has been removed from the feature files and from the test agents
* Update UUIDSerializer and UUIDDeserializer feature files to align with 1.5.8 * Update python and java test agents to align with 1.5.8 for uuid serializer and deserializer
* Update support for Rust, Python, Java Test Agents to 1.5.8 * Update register_and_unregister feature file for 1.5.8
* Update registerandsend feature file to 1.5.8 * update step implementations to support updates to 1.5.8
Contributor
Author
* Update registerandinvoke feature file to 1.5.8 * Update Java and Python Test Agents to support 1.5.8
matthewd0123
force-pushed
the
feature/register_and_invoke_1.5.8
branch
from
3b2643d to
3bac7dd
Compare
matthewd0123
changed the title
| return UStatus(code=UCode.OK, message="OK") | ||
|
|
||
| def register_listener(self, topic: UUri, listener: UListener) -> UStatus: | ||
| def register_listener(self, source_filter: UUri, listener: UListener, sink_filer: UUri = None) -> UStatus: |
There was a problem hiding this comment.
my understanding is to consider both source and sink filter while registering... Not sure how the exact flow looks like in terms each of the filter.
This is important to have a combination of source filter and sink filter to store listeners, for service to send the response to the source that has initiated the request.
* Make updates from Divya Vuppala's comments.
matthewd0123
force-pushed
the
feature/register_and_invoke_1.5.8
branch
from
e42f544 to
c72d538
Compare
* Update socket transport for rust to 1.5.8
matthewd0123
force-pushed
the
feature/register_and_invoke_1.5.8
branch
7 times, most recently
from
6186617 to
818c036
Compare
gregmedd
suggested changes
Jul 18, 2024
Contributor
gregmedd
left a comment
gregmedd
left a comment
There was a problem hiding this comment.
This pull request is far too large for a meaningful review. This must be split into smaller pull requests before it can be accepted into this project.
Contributor
Author
|
@gregmedd totally agree, I have this in draft because I'm collecting all 1.5.8 changes. Will split once it's ready for review |
Contributor
|
My recommendation for splitting this PR would be to provide one PR for each 1.5.8/1.6.0 language update, then to add new features as one or a series of pull requests after those. |
agosh01
reviewed
Jul 19, 2024
| And sets "attributes.source.resource_id" to "32769" | ||
| And sets "attributes.priority" to "UPRIORITY_CS1" | ||
| And sets "attributes.type" to "UMESSAGE_TYPE_PUBLISH" | ||
| And sets "attributes.commstatus" to "OK" |
Member
There was a problem hiding this comment.
remove this not allowed for send umessage
* Allow for arbitrary number of Test Agents in a given test * Update rust to 0.1.1 release * Remove invoke_method, as it is L2 API * Add few tests for streamer
matthewd0123
force-pushed
the
feature/register_and_invoke_1.5.8
branch
from
818c036 to
f72166d
Compare
* Update Python Test Agent * Update Python Test Manager * Update TCK Step Implementations * Update uuid_validator feature
* Update Python Test Agent * Update Python Test Manager * Update TCK Step Implementations * Update uuid_validator feature
…atthewd0123/up-tck into feature/update_python_to_1.5.8
* Align UriValidator test with v1.5.8 * Update Python and Java TAs to work with UriValidator * Create skeleton for 1.5.8 version of SocketUTransports in Python and Java (still requires work after this PR) * Update Test Manager port (was causing issues locally, changing it fixed the issue) * Remove some deprecated code from Python and Java Test Agents
* Align UUIDValidator test with v1.5.8
* Update UAttributesValidator Feature file to 1.5.8 * Update Python Test Agent to align with 1.5.8
* Remove Long and Micro URI references in code * Add new UriSerializer and UriDeserializer feature files for 1.5.8 * Update python and java to align to uriserializer and deserializer for 1.5.8
Since up-java doesn't use is_notification_destination, this has been removed from the feature files and from the test agents
* Update UUIDSerializer and UUIDDeserializer feature files to align with 1.5.8 * Update python and java test agents to align with 1.5.8 for uuid serializer and deserializer
* Update support for Rust, Python, Java Test Agents to 1.5.8 * Update register_and_unregister feature file for 1.5.8
* Update registerandsend feature file to 1.5.8 * update step implementations to support updates to 1.5.8
* Update registerandinvoke feature file to 1.5.8 * Update Java and Python Test Agents to support 1.5.8
* Make updates from Divya Vuppala's comments.
* Update socket transport for rust to 1.5.8
* Allow for arbitrary number of Test Agents in a given test * Update rust to 0.1.1 release * Remove invoke_method, as it is L2 API * Add few tests for streamer
…m/matthewd0123/up-tck into feature/register_and_invoke_1.5.8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.