Align CI with up-cpp CI#113
Merged
PLeVasseur merged 4 commits intoeclipse-uprotocol:mainfrom Mar 3, 2025
Merged
Conversation
|
This looks to pass! I'll defer to @gregmedd to see if he has any feedback this week. If not, I'll go ahead and review and merge later in the week. |
I will go ahead and review when this is updated like mentioned in here.
|
…-version pin ubuntu version 22.04 and clang-tidy 12
Contributor
Author
PLeVasseur
approved these changes
Mar 3, 2025
PLeVasseur
left a comment
PLeVasseur
left a comment
There was a problem hiding this comment.
All looks to pass. Thanks for your help aligning!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligning the CI with that from up-cpp. Inlude the Valgrind checks, conan profile and pinning of the version. Issue 80