add zenoh-c/zenoh-pico backend#126
Draft
pkleymonov-qnx wants to merge 5 commits intoeclipse-uprotocol:mainfrom
Draft
add zenoh-c/zenoh-pico backend#126pkleymonov-qnx wants to merge 5 commits intoeclipse-uprotocol:mainfrom
pkleymonov-qnx wants to merge 5 commits intoeclipse-uprotocol:mainfrom
Conversation
PLeVasseur
reviewed
Nov 27, 2025
PLeVasseur
left a comment
PLeVasseur
left a comment
There was a problem hiding this comment.
Hi @pkleymonov-qnx -- again, sorry for the delay on these reviews.
Looks good to me overall.
Once eclipse-uprotocol/up-conan-recipes#38 merges, let's have you apply the suggestions here, and try to pass CI.
| 3. [zenoh-c][zenoh-repo] - `conan create --version 1.2.1 zenohc-tmp/prebuilt` | ||
| 4. [zenoh-c][zenoh-repo] - | ||
| `conan create --version 1.2.1 zenohcpp-tmp/from-source` | ||
| `conan create --version 1.0.1-dev --build=missing up-cpp/developer -o commitish=af55b7899fb8d2e30de1b11f975750e9d1135bbd -o fork=qnx-ports/up-cpp` |
There was a problem hiding this comment.
Why are we doing this here?
-o fork=qnx-ports/up-cpp
Contributor
Author
There was a problem hiding this comment.
Hey @PLeVasseur
It was a workaround for non-standard int types.
Fixed by eclipse-uprotocol/up-cpp#328
Contributor
Author
There was a problem hiding this comment.
will be updated soon
Co-authored-by: Pete LeVasseur <plevasseur@gmail.com>
Co-authored-by: Pete LeVasseur <plevasseur@gmail.com>
Co-authored-by: Pete LeVasseur <plevasseur@gmail.com>
Co-authored-by: Pete LeVasseur <plevasseur@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add zenoh-c/zenoh-pico backend
This PR depends on corresponding changes:
up-cpp PR: eclipse-uprotocol/up-cpp#328 - fix standard uint32_t/uint16_t types
up-conan-recipes PR: eclipse-uprotocol/up-conan-recipes#38 - extension for new backends