Replace CCombo3 with native SWT CCombo #1092
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both widgets behave effectively the same so there is no need for out custom implementation when the functionality is already provided. Due to 5064677, the CCombo3 widget also doesn't work anymore, because unlike the CImageLabel, the CLabel always sets the SWT.NO_FOCUS bit which is causing issues with the drop-down table. Closes eclipse-windowbuilder#1090
|
Removing the widget alltogether is propably the better choice but that's too risky for the R1. Will be delayed for the M1 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both widgets behave effectively the same so there is no need for out custom implementation when the functionality is already provided.
Due to 5064677, the CCombo3 widget also doesn't work anymore, because unlike the CImageLabel, the CLabel always sets the SWT.NO_FOCUS bit which is causing issues with the drop-down table.
Closes #1090