Detect change on network interface to update locators and scouting #1824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR missing one of the required labels: {'bug', 'internal', 'breaking-change', 'new feature', 'documentation', 'enhancement', 'dependencies'} |
|
A few changes:
There's an additional caveat, the "reset" of the scouting routine may interrupt something important (e.g. the connection to a peer). |
Hugal31
force-pushed
the
feature/netlink-monitor
branch
from
5d2a194 to
3d7c115
Compare
Hugal31
force-pushed
the
feature/netlink-monitor
branch
from
3d7c115 to
8dc2681
Compare
added 9 commits
April 7, 2025 09:41
On Unix systems, use netlink to detect added or delete IPv4 addresses to: * Renew the interface list. * Update the node locators. * Restart the scouting to use the new addresses/discard the old addresses. This is still quite hacky, with the following shortcommings: * We do not handle IPv6 addresses. * We perform the locator update and the scouting reset even if the new/old addresses are not used as per the configuration. * The code overall is not the best quality.
Remove the scouting reset upon interface change. This is in preparation of an improvemnt of the scouting update upon interface change.
Hugal31
force-pushed
the
feature/netlink-monitor
branch
from
8dc2681 to
8c686fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Unix systems, use netlink to detect added or delete IPv4 addresses to:
This is still quite hacky, with the following shortcomings:
This would solve #1823 (with the mentioned caveats).
Feel free to close this, I opened it more for reference and I might not update it.