Skip to content

pass callback argument by reference #1857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

wyfo
Copy link
Contributor

@wyfo wyfo commented Mar 26, 2025

based on #1828

Copy link

PR missing one of the required labels: {'enhancement', 'internal', 'dependencies', 'new feature', 'documentation', 'breaking-change', 'bug'}

@wyfo wyfo force-pushed the callback_by_ref branch from 20e087b to 8664b70 Compare March 26, 2025 15:06
Copy link

PR missing one of the required labels: {'internal', 'bug', 'new feature', 'enhancement', 'documentation', 'breaking-change', 'dependencies'}

@wyfo wyfo force-pushed the callback_by_ref branch from 8664b70 to 584face Compare March 27, 2025 12:55
Copy link

PR missing one of the required labels: {'dependencies', 'bug', 'new feature', 'breaking-change', 'enhancement', 'internal', 'documentation'}

@wyfo wyfo added the internal Changes not included in the changelog label Mar 27, 2025
@wyfo wyfo force-pushed the callback_by_ref branch 3 times, most recently from ffb816a to 632824b Compare March 27, 2025 13:39
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

Attention: Patch coverage is 89.00709% with 31 lines in your changes missing coverage. Please review.

Project coverage is 71.18%. Comparing base (1a10597) to head (4ffcbd3).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
zenoh-ext/src/advanced_subscriber.rs 0.00% 5 Missing ⚠️
zenoh/src/api/session.rs 95.65% 4 Missing ⚠️
io/zenoh-transport/src/common/pipeline.rs 75.00% 3 Missing ⚠️
zenoh/src/api/handlers/callback.rs 82.35% 3 Missing ⚠️
zenoh/src/api/matching.rs 0.00% 3 Missing ⚠️
zenoh/src/api/query.rs 0.00% 3 Missing ⚠️
zenoh/src/api/queryable.rs 0.00% 3 Missing ⚠️
zenoh/src/api/scouting.rs 0.00% 3 Missing ⚠️
zenoh-ext/src/querying_subscriber.rs 0.00% 2 Missing ⚠️
zenoh/src/api/handlers/fifo.rs 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1857      +/-   ##
==========================================
- Coverage   71.18%   71.18%   -0.01%     
==========================================
  Files         364      364              
  Lines       65647    65551      -96     
==========================================
- Hits        46733    46662      -71     
+ Misses      18914    18889      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wyfo wyfo marked this pull request as ready for review March 27, 2025 16:44
@wyfo wyfo force-pushed the callback_by_ref branch from 667ede5 to 48983e7 Compare March 31, 2025 09:09
@wyfo wyfo force-pushed the callback_by_ref branch from 48983e7 to 8e7007f Compare April 9, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes not included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant