-
Notifications
You must be signed in to change notification settings - Fork 190
Make sure that UDP transports remain open when UDP listener is closed #1859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
PR missing one of the required labels: {'dependencies', 'bug', 'new feature', 'documentation', 'enhancement', 'internal', 'breaking-change'} |
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
let result = ztimeout!(client_manager.open_transport_unicast(e.clone())); | ||
assert!(result.is_err()); | ||
// Short timeout for connectionless protocols like udp and quick | ||
let x = tokio::time::timeout( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it should fail and we are expecting a different timeout, I rather change the timeout in the config.
The expected error should be clear and not ambiguous.
E.g., I would rather explicitly set the open_timeout
config parameter to ensure the timeout happens internally and the open_transport_unicast()
returns an error.
Line 450 in 0e0c5d9
open_timeout: 10000, |
c45e7c4
to
9c36155
Compare
No description provided.