Intercept during routing

[fuzzypixelz]

Depends on #1828.

[codecov]

Codecov Report

Attention: Patch coverage is 60.04326% with 1293 lines in your changes missing coverage. Please review.

Project coverage is 71.15%. Comparing base (83b874e) to head (34014ff).

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
zenoh/src/net/routing/hat/router/queries.rs	24.82%	215 Missing ⚠️
zenoh/src/net/routing/hat/linkstate_peer/pubsub.rs	24.18%	163 Missing ⚠️
zenoh/src/net/routing/hat/router/pubsub.rs	42.90%	161 Missing ⚠️
...enoh/src/net/routing/hat/linkstate_peer/queries.rs	27.97%	139 Missing ⚠️
zenoh/src/net/routing/hat/router/token.rs	56.84%	123 Missing ⚠️
zenoh/src/net/routing/hat/linkstate_peer/token.rs	50.54%	90 Missing ⚠️
zenoh/src/net/routing/hat/p2p_peer/queries.rs	59.57%	76 Missing ⚠️
zenoh/src/net/routing/hat/p2p_peer/pubsub.rs	66.21%	74 Missing ⚠️
zenoh/src/net/routing/hat/p2p_peer/token.rs	68.44%	71 Missing ⚠️
zenoh/src/net/routing/hat/client/token.rs	59.85%	55 Missing ⚠️
... and 10 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1864      +/-   ##
==========================================
- Coverage   71.28%   71.15%   -0.14%     
==========================================
  Files         364      364              
  Lines       65664    65605      -59     
==========================================
- Hits        46807    46679     -128     
- Misses      18857    18926      +69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[fuzzypixelz]

Here are is a throughput performance comparison for 8-byte payloads with ACL enabled both on the publisher & the subscriber side between 9ad5304 (main) and 5fae354 (this pull request):

We gain more than 300k messages per second for the median (as well as the mean) throughput on an Ubuntu Server 24.04 machine with a 12th Gen Intel(R) Core(TM) i5-1240P and 16GB of memory.

[DenisBiryukov91]

maybe just .collect_vec() ?

[fuzzypixelz]

I'd like to avoid depending on itertools.

[DenisBiryukov91]

They are still being used across zenoh crate (i.e. in low-pass and publisher builder)

[fuzzypixelz]

Right. But I don't see the value of saving a few characters at the cost of making it harder to remove itertools down the line...

[DenisBiryukov91]

maybe just collect_vec() ?

[DenisBiryukov91]

get_interceptor_cache(...) is probably a better name

[fuzzypixelz]

In Rust the "get" prefix is often considered superfluous.

See https://rust-lang.github.io/api-guidelines/naming.html#getter-names-follow-rust-convention-c-getter.

[wyfo]

I don't really like the .not() and the fact that you don't use ?. Why not:

Suggested change

	match flow {
	InterceptorFlow::Egress => &self.eg_interceptors,
	InterceptorFlow::Ingress => &self.in_interceptors,
	}
	.as_ref()
	.map(|iceptors| iceptors.load())
	.and_then(|iceptors| iceptors.is_empty().not().then_some(iceptors))
	let interceptors = match flow {
	InterceptorFlow::Egress => &self.eg_interceptors,
	InterceptorFlow::Ingress => &self.in_interceptors,
	};
	Some(interceptors.as_ref()?.load()).filter(|i| !i.is_empty())