Skip to content

Optimize shm watchdog storage #1869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Optimize shm watchdog storage #1869

wants to merge 11 commits into from

Conversation

yellowhatter
Copy link
Contributor

No description provided.

@yellowhatter yellowhatter added the enhancement Existing things could work better label Apr 2, 2025
@yellowhatter yellowhatter self-assigned this Apr 2, 2025
@codecov Codecov
Copy link

codecov bot commented Apr 2, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.81988% with 18 lines in your changes missing coverage. Please review.

Project coverage is 71.11%. Comparing base (d07f1d5) to head (31d93dc).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
commons/zenoh-shm/src/metadata/descriptor.rs 77.14% 8 Missing ⚠️
commons/zenoh-shm/src/watchdog/periodic_task.rs 63.63% 4 Missing ⚠️
commons/zenoh-shm/src/api/client_storage/mod.rs 50.00% 3 Missing ⚠️
commons/zenoh-shm/src/watchdog/confirmator.rs 93.02% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1869      +/-   ##
==========================================
+ Coverage   71.05%   71.11%   +0.05%     
==========================================
  Files         364      364              
  Lines       65480    65542      +62     
==========================================
+ Hits        46530    46610      +80     
+ Misses      18950    18932      -18

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yellowhatter
fix clippy
015ad66
@yellowhatter
- HashMap -> BTreeMap
a3588f8 
- Optimize global segment ID generation and indexing
- Optimize some structures on stack
- Mutex -> RWLock
@yellowhatter
Store confirmed metadata without Arc - that improves perf as ShmBufIn…
19dd22c 
…ner is now not sensitive to it's size
@yellowhatter yellowhatter marked this pull request as ready for review April 3, 2025 06:51
@yellowhatter yellowhatter requested a review from YuanYuYuan April 3, 2025 06:52
@yellowhatter yellowhatter added the release Part of the next release label Apr 3, 2025
@yellowhatter
Copy link
Contributor Author

Finally, around 600k msgs\sec added in SHM mode (2.4 -> 3M)
This is not the final optimization, more things to be done (in another PR)

@yellowhatter yellowhatter requested review from YuanYuYuan and removed request for YuanYuYuan April 3, 2025 07:00
@yellowhatter yellowhatter removed the release Part of the next release label Apr 4, 2025
@yellowhatter yellowhatter marked this pull request as draft April 4, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuanYuYuan YuanYuYuan Awaiting requested review from YuanYuYuan

Assignees

@yellowhatter yellowhatter

Labels
enhancement Existing things could work better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yellowhatter